You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/09 02:53:25 UTC
[GitHub] [dubbo-go] cvictory opened a new pull request #916: Optimize the memory usage
cvictory opened a new pull request #916:
URL: https://github.com/apache/dubbo-go/pull/916
What this PR does:
Optimize some memory usage issue , please refer to #901
In this way, we can remove some lock for it is cloned in MergeURL
Which issue(s) this PR fixes:
Fixes #901
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #916: Optimize the memory usage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #916:
URL: https://github.com/apache/dubbo-go/pull/916#issuecomment-741493387
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=h1) Report
> Merging [#916](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=desc) (29e6cff) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/25ed35dbcf25569e8cd045ab95550690e4076403?el=desc) (25ed35d) will **decrease** coverage by `0.03%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #916 +/- ##
===========================================
- Coverage 59.85% 59.82% -0.04%
===========================================
Files 260 260
Lines 12854 12858 +4
===========================================
- Hits 7694 7692 -2
- Misses 4199 4202 +3
- Partials 961 964 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/916/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `57.46% <75.00%> (+0.86%)` | :arrow_up: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/916/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/916/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `72.72% <0.00%> (-3.04%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/916/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `77.17% <0.00%> (-2.18%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/916/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/916/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `69.60% <0.00%> (+0.88%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=footer). Last update [25ed35d...08a13cf](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #916: Optimize the memory usage
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #916:
URL: https://github.com/apache/dubbo-go/pull/916#issuecomment-741493387
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=h1) Report
> Merging [#916](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=desc) (29e6cff) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/25ed35dbcf25569e8cd045ab95550690e4076403?el=desc) (25ed35d) will **decrease** coverage by `0.06%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #916 +/- ##
===========================================
- Coverage 59.85% 59.79% -0.07%
===========================================
Files 260 260
Lines 12854 12858 +4
===========================================
- Hits 7694 7688 -6
- Misses 4199 4205 +6
- Partials 961 965 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/916/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `57.46% <75.00%> (+0.86%)` | :arrow_up: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/916/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.90% <0.00%> (-4.88%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/916/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/916/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `72.72% <0.00%> (-3.04%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/916/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/916/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `77.17% <0.00%> (-2.18%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/916/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/916/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `69.60% <0.00%> (+0.88%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=footer). Last update [25ed35d...29e6cff](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cvictory commented on a change in pull request #916: Optimize the memory usage
Posted by GitBox <gi...@apache.org>.
cvictory commented on a change in pull request #916:
URL: https://github.com/apache/dubbo-go/pull/916#discussion_r539041520
##########
File path: common/url.go
##########
@@ -427,6 +427,17 @@ func (c *URL) SetParam(key string, value string) {
c.params.Set(key, value)
}
+// SetParams will replace the URL.params
+// SetParams will put all key-value pair into url.
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #916: Optimize the memory usage
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #916:
URL: https://github.com/apache/dubbo-go/pull/916#issuecomment-741571426
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #916: Optimize the memory usage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #916:
URL: https://github.com/apache/dubbo-go/pull/916#issuecomment-741493387
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=h1) Report
> Merging [#916](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=desc) (29e6cff) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/25ed35dbcf25569e8cd045ab95550690e4076403?el=desc) (25ed35d) will **decrease** coverage by `0.03%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #916 +/- ##
===========================================
- Coverage 59.85% 59.82% -0.04%
===========================================
Files 260 260
Lines 12854 12858 +4
===========================================
- Hits 7694 7692 -2
- Misses 4199 4202 +3
- Partials 961 964 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/916/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `57.46% <75.00%> (+0.86%)` | :arrow_up: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/916/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/916/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `72.72% <0.00%> (-3.04%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/916/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `77.17% <0.00%> (-2.18%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/916/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/916/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `69.60% <0.00%> (+0.88%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=footer). Last update [25ed35d...29e6cff](https://codecov.io/gh/apache/dubbo-go/pull/916?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cvictory merged pull request #916: Optimize the memory usage
Posted by GitBox <gi...@apache.org>.
cvictory merged pull request #916:
URL: https://github.com/apache/dubbo-go/pull/916
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #916: Optimize the memory usage
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #916:
URL: https://github.com/apache/dubbo-go/pull/916#discussion_r539020716
##########
File path: common/url.go
##########
@@ -427,6 +427,17 @@ func (c *URL) SetParam(key string, value string) {
c.params.Set(key, value)
}
+// SetParams will replace the URL.params
+// SetParams will put all key-value pair into url.
Review comment:
This comment and function not match?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org