You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/05 08:41:29 UTC
[GitHub] [incubator-seatunnel] kid-xiong opened a new pull request #1400: implament StructuredStreamingExecution
kid-xiong opened a new pull request #1400:
URL: https://github.com/apache/incubator-seatunnel/pull/1400
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
implement spark structured streaming
closed #1399
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in you PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1400: [Feature][Core]implament StructuredStreamingExecution
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #1400:
URL: https://github.com/apache/incubator-seatunnel/pull/1400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yuangjiang commented on a change in pull request #1400: [Feature][Core]implament StructuredStreamingExecution
Posted by GitBox <gi...@apache.org>.
yuangjiang commented on a change in pull request #1400:
URL: https://github.com/apache/incubator-seatunnel/pull/1400#discussion_r835894697
##########
File path: seatunnel-common/src/main/java/org/apache/seatunnel/common/constants/JobMode.java
##########
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.common.constants;
+
+public enum JobMode {
+ BATCH, STREAMING, STRUCTURED_STREAMING
Review comment:
spark structured streaming and spark dstream cannot be initialized at the same time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kid-xiong commented on a change in pull request #1400: [Feature][Core]implament StructuredStreamingExecution
Posted by GitBox <gi...@apache.org>.
kid-xiong commented on a change in pull request #1400:
URL: https://github.com/apache/incubator-seatunnel/pull/1400#discussion_r822773171
##########
File path: seatunnel-common/src/main/java/org/apache/seatunnel/common/constants/JobMode.java
##########
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.common.constants;
+
+public enum JobMode {
+ BATCH, STREAMING, STRUCTURED_STREAMING
Review comment:
It won't cause compile error. When there are no other methods and fields in an enumeration, it can be omitted
About jobmode, I think it is tally with the design. It is a job working mode and has nothing to do with the engine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a change in pull request #1400: [Feature][Core]implament StructuredStreamingExecution
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #1400:
URL: https://github.com/apache/incubator-seatunnel/pull/1400#discussion_r824331269
##########
File path: seatunnel-common/src/main/java/org/apache/seatunnel/common/constants/JobMode.java
##########
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.common.constants;
+
+public enum JobMode {
+ BATCH, STREAMING, STRUCTURED_STREAMING
Review comment:
Yes, it can compile success.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a change in pull request #1400: implament StructuredStreamingExecution
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #1400:
URL: https://github.com/apache/incubator-seatunnel/pull/1400#discussion_r820237622
##########
File path: seatunnel-common/src/main/java/org/apache/seatunnel/common/constants/JobMode.java
##########
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.common.constants;
+
+public enum JobMode {
+ BATCH, STREAMING, STRUCTURED_STREAMING
Review comment:
Missing `;` here cause compile error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kid-xiong commented on a change in pull request #1400: [Feature][Core]implament StructuredStreamingExecution
Posted by GitBox <gi...@apache.org>.
kid-xiong commented on a change in pull request #1400:
URL: https://github.com/apache/incubator-seatunnel/pull/1400#discussion_r822773171
##########
File path: seatunnel-common/src/main/java/org/apache/seatunnel/common/constants/JobMode.java
##########
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.common.constants;
+
+public enum JobMode {
+ BATCH, STREAMING, STRUCTURED_STREAMING
Review comment:
It won't cause compile error, but it's really nonstandard. I'll fix it.
About jobmode, I think it is tally with the design. It is a job working mode and has nothing to do with the engine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kid-xiong commented on a change in pull request #1400: [Feature][Core]implament StructuredStreamingExecution
Posted by GitBox <gi...@apache.org>.
kid-xiong commented on a change in pull request #1400:
URL: https://github.com/apache/incubator-seatunnel/pull/1400#discussion_r822786140
##########
File path: seatunnel-common/src/main/java/org/apache/seatunnel/common/constants/JobMode.java
##########
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.common.constants;
+
+public enum JobMode {
+ BATCH, STREAMING, STRUCTURED_STREAMING
Review comment:
We can involve more people in the discussion，@[CalvinKirs](https://github.com/CalvinKirs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a change in pull request #1400: [Feature][Core]implament StructuredStreamingExecution
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #1400:
URL: https://github.com/apache/incubator-seatunnel/pull/1400#discussion_r824333938
##########
File path: seatunnel-common/src/main/java/org/apache/seatunnel/common/constants/JobMode.java
##########
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.common.constants;
+
+public enum JobMode {
+ BATCH, STREAMING, STRUCTURED_STREAMING
Review comment:
The ci is failed, you can rebase from master then this will be solved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1400: [Feature][Core]implament StructuredStreamingExecution
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1400:
URL: https://github.com/apache/incubator-seatunnel/pull/1400#issuecomment-1077523485
hi, how’s it going
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1400: [Feature][Core]implament StructuredStreamingExecution
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1400:
URL: https://github.com/apache/incubator-seatunnel/pull/1400#discussion_r836008211
##########
File path: seatunnel-common/src/main/java/org/apache/seatunnel/common/constants/JobMode.java
##########
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.common.constants;
+
+public enum JobMode {
+ BATCH, STREAMING, STRUCTURED_STREAMING
Review comment:
Since this PR has been put on hold for a long time, and there is no plugin for spark stream, I will merge it first, and then solve the problem here. Thank you for your reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1400: [Feature][Core]implament StructuredStreamingExecution
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1400:
URL: https://github.com/apache/incubator-seatunnel/pull/1400#discussion_r827169335
##########
File path: seatunnel-common/src/main/java/org/apache/seatunnel/common/constants/JobMode.java
##########
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.common.constants;
+
+public enum JobMode {
+ BATCH, STREAMING, STRUCTURED_STREAMING
Review comment:
CI failure has nothing to do with this PR, just need to update the code 🤣
##########
File path: seatunnel-common/src/main/java/org/apache/seatunnel/common/constants/JobMode.java
##########
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.common.constants;
+
+public enum JobMode {
+ BATCH, STREAMING, STRUCTURED_STREAMING
Review comment:
CI failure has nothing to do with this PR, just need to update the code 🤣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org