You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by jp...@apache.org on 2013/04/18 18:21:23 UTC
git commit: TS-1755: Fix shell script standards review comments
Updated Branches:
refs/heads/master dcd75114c -> 311abc01c
TS-1755: Fix shell script standards review comments
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/311abc01
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/311abc01
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/311abc01
Branch: refs/heads/master
Commit: 311abc01c2d0567a7ab2ea01b86190b85c08c3cc
Parents: dcd7511
Author: James Peach <jp...@apache.org>
Authored: Thu Apr 18 09:20:46 2013 -0700
Committer: James Peach <jp...@apache.org>
Committed: Thu Apr 18 09:20:46 2013 -0700
----------------------------------------------------------------------
proxy/tests/test_logstats_json | 8 ++++----
proxy/tests/test_logstats_summary | 10 +++++-----
2 files changed, 9 insertions(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/311abc01/proxy/tests/test_logstats_json
----------------------------------------------------------------------
diff --git a/proxy/tests/test_logstats_json b/proxy/tests/test_logstats_json
index 58de9f7..5fd7b5b 100755
--- a/proxy/tests/test_logstats_json
+++ b/proxy/tests/test_logstats_json
@@ -18,9 +18,9 @@
set -e # exit on error
-TMPFILE=`mktemp -t logstats.XXXXXX` || exit 1
+tmpfile=$(mktemp -t logstats.XXXXXX)
# Note that the JSON has a timestamp in it that we have to filter out ...
-./traffic_logstats --log_file "$srcdir/tests/logstats.blog" --json | grep -v timestamp > $TMPFILE
-diff -q $TMPFILE "$srcdir/tests/logstats.json"
-rm -f $TMPFILE
+./traffic_logstats --log_file "$srcdir/tests/logstats.blog" --json | grep -v timestamp > "$tmpfile"
+diff -q "$tmpfile" "$srcdir/tests/logstats.json"
+rm -f -- "$tmpfile"
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/311abc01/proxy/tests/test_logstats_summary
----------------------------------------------------------------------
diff --git a/proxy/tests/test_logstats_summary b/proxy/tests/test_logstats_summary
index e41a33e..0aee4ab 100755
--- a/proxy/tests/test_logstats_summary
+++ b/proxy/tests/test_logstats_summary
@@ -1,4 +1,4 @@
-#! /usr/bin/env sh
+#! /usr/bin/env bash
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
@@ -18,8 +18,8 @@
set -e # exit on error
-TMPFILE=`mktemp -t logstats.XXXXXX` || exit 1
+tmpfile=$(mktemp -t logstats.XXXXXX)
-./traffic_logstats --log_file "$srcdir/tests/logstats.blog" --summary > $TMPFILE
-diff -q $TMPFILE "$srcdir/tests/logstats.summary"
-rm -f $TMPFILE
+./traffic_logstats --log_file "$srcdir/tests/logstats.blog" --summary > "$tmpfile"
+diff -q "$tmpfile" "$srcdir/tests/logstats.summary"
+rm -f -- "$tmpfile"