Re: Review Request 25155: Fix KAFKA-1616

[Guozhang Wang <gu...@linkedin.com>]

> On Aug. 28, 2014, 11:44 p.m., Jun Rao wrote:
> > core/src/main/scala/kafka/server/RequestPurgatory.scala, line 258
> > <https://reviews.apache.org/r/25155/diff/2/?file=671427#file671427line258>
> >
> >     I am wonder if we should do two separate tests: (1) if enqueued() >= purgeInterval, we purge the dealyed queue, (2) if size >= purgeInterval, we purge the watchers.

Added one test in RequestPurgatoryTest, which tests the number of watched elements and the enqueued requests before and after the purging.


- Guozhang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25155/#review51850
-----------------------------------------------------------


On Aug. 28, 2014, 5:12 p.m., Guozhang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25155/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2014, 5:12 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1616
>     https://issues.apache.org/jira/browse/KAFKA-1616
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Purgatory size to be the sum of watched list sizes; delayed request to be the expiry queue length; remove atomic integers for metrics
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/server/RequestPurgatory.scala ce06d2c381348deef8559374869fcaed923da1d1 
> 
> Diff: https://reviews.apache.org/r/25155/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guozhang Wang
> 
>