[GitHub] [incubator-druid] leventov edited a comment on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

[GitBox <gi...@apache.org>]

leventov edited a comment on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments
URL: https://github.com/apache/incubator-druid/pull/7306#issuecomment-477380826
 
 
   > But if possible, it benefits everyone (users & developers alike) to have consistent terminology across the entire system.
   
   I'm not sure that a column in `sys.segments` and the internal codebase concept (currently "used segments") are *the same thing*. Calling them the same may add more confusion and make navigation in the codebase harder than if the names are different. For example, if `sys.segments` concept is called "published" and somebody sees "published" in code, they know it's about the virtual SQL table, not the table in the metadata store.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org