[jira] [Commented] (KAFKA-9780) Deprecate commit records without record metadata

["Randall Hauch (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072911#comment-17072911 ] 

Randall Hauch commented on KAFKA-9780:
--------------------------------------

Thanks, [~mmolimar].

First, we will definitely need a KIP to deprecate the method and plan to remove it in a future major release. See [https://cwiki.apache.org/confluence/display/KAFKA/KIP-528%3A+Deprecate+PartitionGrouper+configuration+and+interface] for an example of a simple KIP that deprecates part of the API – this KIP would be even simpler.

Second, I would be fine with deprecating the older method, since that probably should have been done in the KIP when the new method was added. Be that as it may, IMO the KIP should propose *deprecating* the method but should *not propose removing* the method in AK 3.0.0. Unlike Kafka Streams or even the Kafka client libraries, it is very common for Kafka Connect connector implementations to be deployed in older Connect runtimes. As such, we work hard to keep the API backward compatible and have been quite successful. Removing the method prematurely would only mean that older connector implementations/versions could not be installed into newer Connect runtimes, yet it's not clear to me why we'd want to do that just to remove a method, especially because that AK 3.0.0 could potentially be <1 year away, leaving relatively little time for connectors to be changed and re-released.

> Deprecate commit records without record metadata
> ------------------------------------------------
>
>                 Key: KAFKA-9780
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9780
>             Project: Kafka
>          Issue Type: Improvement
>          Components: KafkaConnect
>    Affects Versions: 2.4.1
>            Reporter: Mario Molina
>            Assignee: Mario Molina
>            Priority: Minor
>              Labels: needs-kip
>             Fix For: 2.6.0
>
>
> Since KIP-382 (MirrorMaker 2.0) a new method {{commitRecord}} was included in {{SourceTask}} class to be called by the worker adding a new parameter with the record metadata. The old {{commitRecord}} method is called and from the new one and it's preserved just for backwards compatibility.
> The idea is to deprecate this method so that we could remove it in a future release.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)