You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "rmuir (via GitHub)" <gi...@apache.org> on 2025/07/29 08:13:20 UTC
[PR] remove IndexReader.registerParentReader() [lucene]
rmuir opened a new pull request, #15002:
URL: https://github.com/apache/lucene/pull/15002
Remove this function and associated WeakhashMap: it is not needed any more. The tests still pass, user still gets ACE (just slightly different exception message).
Closes #14999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] remove IndexReader.registerParentReader() [lucene]
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #15002:
URL: https://github.com/apache/lucene/pull/15002#issuecomment-3131603823
I marked this for 11.0. Please add a changes.txt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] remove IndexReader.registerParentReader() [lucene]
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on code in PR #15002:
URL: https://github.com/apache/lucene/pull/15002#discussion_r2239174129
##########
lucene/core/src/test/org/apache/lucene/index/TestReaderClosed.java:
##########
@@ -105,9 +105,7 @@ public void testReaderChaining() throws Exception {
if (ace == null) {
throw new AssertionError("Query failed, but not due to an AlreadyClosedException", e);
}
- assertEquals(
- "this IndexReader cannot be used anymore as one of its child readers was closed",
- ace.getMessage());
+ assertEquals("this IndexReader is closed", ace.getMessage());
Review Comment:
I am not sure if this exact message is thrown by all directory implementations. Maybe just check for the type of exection and ignore message. So just remove this line.
See the test name "testReaderChaining", maybe remove it completely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] remove IndexReader.registerParentReader() [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #15002:
URL: https://github.com/apache/lucene/pull/15002#issuecomment-3131208746
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] remove IndexReader.registerParentReader() [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir merged PR #15002:
URL: https://github.com/apache/lucene/pull/15002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org