[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24534: [SPARK-27639][SQL] InMemoryTableScan shows the table name on UI if possible

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #24534: [SPARK-27639][SQL] InMemoryTableScan shows the table name on UI if possible
URL: https://github.com/apache/spark/pull/24534#discussion_r281404154
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala
 ##########
 @@ -36,6 +36,15 @@ case class InMemoryTableScanExec(
     @transient relation: InMemoryRelation)
   extends LeafExecNode with ColumnarBatchScan {
 
+  override val nodeName: String = {
+    relation.cacheBuilder.tableName match {
+      case Some(tableName) =>
+        s"Scan in memory table ${tableName.replace("`", "")}"
 
 Review comment:
   @wangyum . Could you improve this more because we allow the backtick in `tableName`?
   ```scala
   scala> sql("create temporary view ab as select 1")
   
   scala> sql("create temporary view ```a``b``` as select 100000")
   
   scala> sql("show tables").show
   +--------+---------+-----------+
   |database|tableName|isTemporary|
   +--------+---------+-----------+
   |        |    `a`b`|       true|
   |        |       ab|       true|
   +--------+---------+-----------+
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org