You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "yangwei (JIRA)" <ji...@apache.org> on 2013/01/14 04:40:12 UTC
[jira] [Updated] (CASSANDRA-5153) max client timestamp
[ https://issues.apache.org/jira/browse/CASSANDRA-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
yangwei updated CASSANDRA-5153:
-------------------------------
Description:
1. In public LazilyCompactedRow(CompactionController controller, List<? extends ICountableColumnIterator> rows)
columnStats = new ColumnStats(reducer == null ? 0 : reducer.columns, reducer == null ? Long.MIN_VALUE : reducer.maxTimestampSeen,
reducer == null ? new StreamingHistogram(SSTable.TOMBSTONE_HISTOGRAM_BIN_SIZE) : reducer.tombstones
Tthe maxTimestampSeen should be max(emptyColumnFamily.deletionInfo().maxTimestamp(), reducer.maxTimestampSeen)?
2. In private ColumnFamily collectTimeOrderedData()
// if we've already seen a row tombstone with a timestamp greater
// than the most recent update to this sstable, we're done, since the rest of the sstables
// will also be older
if (sstable.getMaxTimestamp() < mostRecentRowTombstone)
break;
In the case that sstable.getMaxTimestamp == Long.MIN_VALUE, is it logical?
> max client timestamp
> --------------------
>
> Key: CASSANDRA-5153
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5153
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.0
> Reporter: yangwei
>
> 1. In public LazilyCompactedRow(CompactionController controller, List<? extends ICountableColumnIterator> rows)
> columnStats = new ColumnStats(reducer == null ? 0 : reducer.columns, reducer == null ? Long.MIN_VALUE : reducer.maxTimestampSeen,
> reducer == null ? new StreamingHistogram(SSTable.TOMBSTONE_HISTOGRAM_BIN_SIZE) : reducer.tombstones
> Tthe maxTimestampSeen should be max(emptyColumnFamily.deletionInfo().maxTimestamp(), reducer.maxTimestampSeen)?
> 2. In private ColumnFamily collectTimeOrderedData()
> // if we've already seen a row tombstone with a timestamp greater
> // than the most recent update to this sstable, we're done, since the rest of the sstables
> // will also be older
> if (sstable.getMaxTimestamp() < mostRecentRowTombstone)
> break;
> In the case that sstable.getMaxTimestamp == Long.MIN_VALUE, is it logical?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira