You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/16 09:19:22 UTC
[GitHub] [airflow] mbarrien opened a new pull request #8396: Fix error
message in production entrypoint.sh
mbarrien opened a new pull request #8396: Fix error message in production entrypoint.sh
URL: https://github.com/apache/airflow/pull/8396
When running Airflow using the Docker production image, I ran into an (unrelated) issue where the database connection timed out. However, instead of seeing the error message telling me about the timeout, I got an error message saying the BACKEND variable didn't exist; an error with the error message. This PR fixes that, replacing it with the original connection string as I believe was intended.
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mbarrien commented on issue #8396: Fix error message in
production entrypoint.sh
Posted by GitBox <gi...@apache.org>.
mbarrien commented on issue #8396: Fix error message in production entrypoint.sh
URL: https://github.com/apache/airflow/pull/8396#issuecomment-614943944
Repointed PR at master base branch, rebased and force-pushed. I will go ahead and check off the boxes above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #8396: Fix error
message in production entrypoint.sh
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #8396: Fix error message in production entrypoint.sh
URL: https://github.com/apache/airflow/pull/8396#issuecomment-614962044
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #8396: Fix error message in
production entrypoint.sh
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #8396: Fix error message in production entrypoint.sh
URL: https://github.com/apache/airflow/pull/8396#issuecomment-614876191
Yeah in this case, for Dockerfile, we don't need to any test or docs for this PR. But can you create a new PR to fix this issue in Master too please?
The workflow is PR is against a Master and one of the Airflow Committers would then backport it to v1-10-* branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #8396: Fix error message in
production entrypoint.sh
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #8396: Fix error message in production entrypoint.sh
URL: https://github.com/apache/airflow/pull/8396
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mbarrien commented on issue #8396: Fix error message in
production entrypoint.sh
Posted by GitBox <gi...@apache.org>.
mbarrien commented on issue #8396: Fix error message in production entrypoint.sh
URL: https://github.com/apache/airflow/pull/8396#issuecomment-614860696
Master also does suffer from this, but I noticed this in my attempts to do 1.10. Don't know what the convention is in this repo for PRs against master and backports.
For the 2 unchecked checkboxes, I don't know if there are any unit tests available to test something like this (and it seems like quite the task to create one to test a Dockerfile). Also don't know what docs need updating for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #8396: Fix error
message in production entrypoint.sh
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #8396: Fix error message in production entrypoint.sh
URL: https://github.com/apache/airflow/pull/8396#issuecomment-614525073
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #8396: Fix error message in
production entrypoint.sh
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #8396: Fix error message in production entrypoint.sh
URL: https://github.com/apache/airflow/pull/8396#issuecomment-614778797
This PR is against v1-10-stable, does Master not suffer from the same issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services