You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/10 20:35:53 UTC

[GitHub] [beam] TheNeuralBit commented on a diff in pull request #21803: Separated pandas and numpy implementations of sklearn.

TheNeuralBit commented on code in PR #21803:
URL: https://github.com/apache/beam/pull/21803#discussion_r894872155


##########
sdks/python/apache_beam/ml/inference/sklearn_inference.py:
##########
@@ -94,9 +91,6 @@ class SklearnModelHandlerPandas(ModelHandler[pandas.DataFrame,
                                              BaseEstimator]):
   """ Implementation of the ModelHandler interface for scikit-learn that
       supports pandas dataframes.
-
-      NOTE: This API and its implementation are under development and
-      do not provide backward compatibility guarantees.

Review Comment:
   I think @robertwb wanted to keep the implementations with named inputs marked experimental



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org