You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "jrudolph (via GitHub)" <gi...@apache.org> on 2023/02/08 12:42:05 UTC
[GitHub] [incubator-pekko-sbt-paradox] jrudolph opened a new pull request, #8: fix scalafmt plugin
jrudolph opened a new pull request, #8:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/8
Was declared in wrong file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] jrudolph commented on a diff in pull request #8: fix scalafmt plugin
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #8:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/8#discussion_r1100080215
##########
project/plugins.sbt:
##########
@@ -2,3 +2,4 @@
// remember to also update build.sbt
addSbtPlugin("com.lightbend.paradox" % "sbt-paradox-theme" % "0.10.3")
addSbtPlugin("com.github.sbt" % "sbt-ci-release" % "1.5.11")
+addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.4.6")
Review Comment:
:+1: done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] mdedetrich commented on a diff in pull request #8: fix scalafmt plugin
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #8:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/8#discussion_r1100079852
##########
project/plugins.sbt:
##########
@@ -2,3 +2,4 @@
// remember to also update build.sbt
addSbtPlugin("com.lightbend.paradox" % "sbt-paradox-theme" % "0.10.3")
addSbtPlugin("com.github.sbt" % "sbt-ci-release" % "1.5.11")
+addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.4.6")
Review Comment:
@jrudolph Newline is missing, scalafmt adds new lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] mdedetrich merged pull request #8: fix scalafmt plugin
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #8:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] mdedetrich commented on pull request #8: fix scalafmt plugin
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #8:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/8#issuecomment-1422537255
@jrudolph Need to run scalafmt on the code you just added https://github.com/apache/incubator-pekko-sbt-paradox/actions/runs/4124203085/jobs/7123174459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] jrudolph commented on pull request #8: fix scalafmt plugin
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #8:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/8#issuecomment-1422537929
There's nothing to format?!?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] mdedetrich commented on pull request #8: fix scalafmt plugin
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #8:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/8#issuecomment-1422563226
Going ahead to merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org