You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/07 23:00:56 UTC
[GitHub] [incubator-mxnet] ptrendx opened a new pull request #17995: Fix
ElemwiseSum for more than 4 inputs
ptrendx opened a new pull request #17995: Fix ElemwiseSum for more than 4 inputs
URL: https://github.com/apache/incubator-mxnet/pull/17995
## Description ##
Fixes #17989
It was caused by a bug in `ElemwiseSum` which for more than 4 inputs and `kAddTo` req was counting gradients multiple times.
@sxjscience @zhreshold Please test if this fixes the issues you saw.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] zhreshold commented on issue #17995: Fix
ElemwiseSum for more than 4 inputs
Posted by GitBox <gi...@apache.org>.
zhreshold commented on issue #17995: Fix ElemwiseSum for more than 4 inputs
URL: https://github.com/apache/incubator-mxnet/pull/17995#issuecomment-610766998
confirmed it can fix https://github.com/apache/incubator-mxnet/issues/16708#issuecomment-558876214 as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17995: Fix ElemwiseSum
for more than 4 inputs
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17995: Fix ElemwiseSum for more than 4 inputs
URL: https://github.com/apache/incubator-mxnet/pull/17995#issuecomment-610666920
Should we add a test case in the style of https://github.com/apache/incubator-mxnet/issues/17989#issuecomment-610591835 to ensure no such bug makes it into the codebase again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17995: Fix
ElemwiseSum for more than 4 inputs
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17995: Fix ElemwiseSum for more than 4 inputs
URL: https://github.com/apache/incubator-mxnet/pull/17995#issuecomment-612190720
Jenkins CI successfully triggered : [unix-gpu, centos-gpu, windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] szha commented on issue #17995: Fix ElemwiseSum
for more than 4 inputs
Posted by GitBox <gi...@apache.org>.
szha commented on issue #17995: Fix ElemwiseSum for more than 4 inputs
URL: https://github.com/apache/incubator-mxnet/pull/17995#issuecomment-612190670
@mxnet-bot run ci [centos-gpu, unix-gpu, windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] sxjscience merged pull request #17995: Fix
ElemwiseSum for more than 4 inputs
Posted by GitBox <gi...@apache.org>.
sxjscience merged pull request #17995: Fix ElemwiseSum for more than 4 inputs
URL: https://github.com/apache/incubator-mxnet/pull/17995
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] szha commented on issue #17995: Fix ElemwiseSum
for more than 4 inputs
Posted by GitBox <gi...@apache.org>.
szha commented on issue #17995: Fix ElemwiseSum for more than 4 inputs
URL: https://github.com/apache/incubator-mxnet/pull/17995#issuecomment-611164666
@ptrendx thanks for the fix. Let's add a test for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ciyongch commented on issue #17995: Fix
ElemwiseSum for more than 4 inputs
Posted by GitBox <gi...@apache.org>.
ciyongch commented on issue #17995: Fix ElemwiseSum for more than 4 inputs
URL: https://github.com/apache/incubator-mxnet/pull/17995#issuecomment-612302541
@ptrendx can you help to backport this PR to v1.x branch? Then I'll rebase v1.7.x to v1.x accordingly. I'm adding this to 1.7.0 roadmap https://github.com/apache/incubator-mxnet/issues/16864.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17995: Fix
ElemwiseSum for more than 4 inputs
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17995: Fix ElemwiseSum for more than 4 inputs
URL: https://github.com/apache/incubator-mxnet/pull/17995#issuecomment-610661204
Hey @ptrendx , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-cpu, miscellaneous, unix-gpu, edge, windows-gpu, website, sanity, centos-cpu, clang, centos-gpu, unix-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] sxjscience commented on issue #17995: Fix
ElemwiseSum for more than 4 inputs
Posted by GitBox <gi...@apache.org>.
sxjscience commented on issue #17995: Fix ElemwiseSum for more than 4 inputs
URL: https://github.com/apache/incubator-mxnet/pull/17995#issuecomment-610704560
@ptrendx I can confirm that this fixes the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ptrendx commented on issue #17995: Fix
ElemwiseSum for more than 4 inputs
Posted by GitBox <gi...@apache.org>.
ptrendx commented on issue #17995: Fix ElemwiseSum for more than 4 inputs
URL: https://github.com/apache/incubator-mxnet/pull/17995#issuecomment-612237050
Added v1.x label even though this PR is targeted for master in order to track that we want it included in 1.7 release @ciyongch FYI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services