You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/04/23 19:34:54 UTC
[GitHub] [arrow] andygrove opened a new pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly
andygrove opened a new pull request #7024:
URL: https://github.com/apache/arrow/pull/7024
Now that Rust 1.43.0 is released, we should upgrade to 1.44 nightly. It looks like there were changes in rustfmt rules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] markhildreth commented on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly
Posted by GitBox <gi...@apache.org>.
markhildreth commented on pull request #7024:
URL: https://github.com/apache/arrow/pull/7024#issuecomment-619273713
@andygrove I think there is going to be more to this than this PR. The "nightly-2019-11-14" string [can be found in a few places](https://github.com/apache/arrow/search?q=nightly-2019-11-14&unscoped_q=nightly-2019-11-14), including some of the build scripts (notice that the workflows run for this PR are still called "2019-11-14").
@nevi-me @paddyhoran The problem with this error seems to be that the change was only made in rust-toolchain. As a result, the GHA workflows will still build a Windows environment with a nightly-2019-11-14 toolchain. When cargo attempts to build, it will notice that the toolchain is out of date with the `rust-toolchain` file, and attempt to pull the new toolchain on-the-fly. However, it doesn't pull `rust fmt` when this occurs.
```
installed toolchains
--------------------
stable-x86_64-pc-windows-msvc
nightly-2019-11-14-x86_64-pc-windows-msvc
active toolchain
----------------
nightly-2019-11-14-x86_64-pc-windows-msvc (directory override for '\\?\D:\a\arrow\arrow')
rustc 1.41.0-nightly (ded5ee001 2019-11-13)
+ mkdir -p /d/a/arrow/arrow/build/rust
+ pushd /d/a/arrow/arrow/rust
/d/a/arrow/arrow/rust /d/a/arrow/arrow
+ RUSTFLAGS='-D warnings'
+ cargo build --all-targets
info: syncing channel updates for 'nightly-2020-04-22-x86_64-pc-windows-msvc'
info: latest update on 2020-04-22, rust version 1.44.0-nightly (45d050cde 2020-04-21)
info: downloading component 'cargo'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: installing component 'cargo'
info: installing component 'rust-std'
info: installing component 'rustc'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #7024:
URL: https://github.com/apache/arrow/pull/7024#issuecomment-619189091
@paddyhoran we might have to try a different nightly, as sometimes a day's version might have no rustfmt. The change I made in that PR installs a nightly version, I don't know how to make GHA install a stable version of rustfmt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me edited a comment on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly
Posted by GitBox <gi...@apache.org>.
nevi-me edited a comment on pull request #7024:
URL: https://github.com/apache/arrow/pull/7024#issuecomment-620649009
@andygrove the failure doesn't make sense to me. On my machine, the relevant file is formatted correctly. @jorisvandenbossche we'll fix the lint CI failure here.
___
@markhildreth a bad case of copy-pasta, apologies
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] markhildreth edited a comment on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly
Posted by GitBox <gi...@apache.org>.
markhildreth edited a comment on pull request #7024:
URL: https://github.com/apache/arrow/pull/7024#issuecomment-619273713
@andygrove I think there is going to be more to this than this PR. The "nightly-2019-11-14" string [can be found in a few places](https://github.com/apache/arrow/search?q=nightly-2019-11-14&unscoped_q=nightly-2019-11-14), including some of the build scripts (notice that the workflows run for this PR are still called "2019-11-14").
@nevi-me @paddyhoran The problem with this error seems to be that the change was only made in rust-toolchain. As a result, the GHA workflows will still build a Rust environment with a nightly-2019-11-14 toolchain. When cargo attempts to build, it will notice that the toolchain is out of date with the `rust-toolchain` file, and attempt to pull the new toolchain on-the-fly. However, it doesn't necessarily pull `rustfmt` when this occurs.
```
installed toolchains
--------------------
stable-x86_64-pc-windows-msvc
nightly-2019-11-14-x86_64-pc-windows-msvc
active toolchain
----------------
nightly-2019-11-14-x86_64-pc-windows-msvc (directory override for '\\?\D:\a\arrow\arrow')
rustc 1.41.0-nightly (ded5ee001 2019-11-13)
+ mkdir -p /d/a/arrow/arrow/build/rust
+ pushd /d/a/arrow/arrow/rust
/d/a/arrow/arrow/rust /d/a/arrow/arrow
+ RUSTFLAGS='-D warnings'
+ cargo build --all-targets
info: syncing channel updates for 'nightly-2020-04-22-x86_64-pc-windows-msvc'
info: latest update on 2020-04-22, rust version 1.44.0-nightly (45d050cde 2020-04-21)
info: downloading component 'cargo'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: installing component 'cargo'
info: installing component 'rust-std'
info: installing component 'rustc'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paddyhoran commented on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly
Posted by GitBox <gi...@apache.org>.
paddyhoran commented on pull request #7024:
URL: https://github.com/apache/arrow/pull/7024#issuecomment-618749586
CI is failing again, I thought this was fixed by #8558
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #7024:
URL: https://github.com/apache/arrow/pull/7024#issuecomment-620649009
@andygrove this failure (https://git.data-engine.co.za/nevi-me/ifrs16-front-end-angular/pipelines/1830) doesn't make sense to me. On my machine, the relevant file is formatted correctly. @jorisvandenbossche we'll fix the lint CI failure here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7024:
URL: https://github.com/apache/arrow/pull/7024#issuecomment-618624379
https://issues.apache.org/jira/browse/ARROW-8573
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paddyhoran edited a comment on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly
Posted by GitBox <gi...@apache.org>.
paddyhoran edited a comment on pull request #7024:
URL: https://github.com/apache/arrow/pull/7024#issuecomment-618749586
CI is failing again, I thought this was fixed by #7010
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] markhildreth edited a comment on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly
Posted by GitBox <gi...@apache.org>.
markhildreth edited a comment on pull request #7024:
URL: https://github.com/apache/arrow/pull/7024#issuecomment-620692002
@nevi-me I don't have access to the failure you linked to (on domain `git.data-engine.co.za`), but if you mean the failure showing up in CI, there was a change (https://github.com/apache/arrow/commit/d094631bbb780bc686bebd9a87a0b3e4aa7e0ff0) to that file on master checked in after this branch was created. Rebasing a local branch onto master should cause the error to appear locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] markhildreth edited a comment on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly
Posted by GitBox <gi...@apache.org>.
markhildreth edited a comment on pull request #7024:
URL: https://github.com/apache/arrow/pull/7024#issuecomment-620692002
@nevi-me there was a change (https://github.com/apache/arrow/commit/d094631bbb780bc686bebd9a87a0b3e4aa7e0ff0) to that file on master checked in after this branch was created. Rebasing a local branch onto master should cause the error to appear locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] markhildreth edited a comment on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly
Posted by GitBox <gi...@apache.org>.
markhildreth edited a comment on pull request #7024:
URL: https://github.com/apache/arrow/pull/7024#issuecomment-620692002
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] markhildreth edited a comment on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly
Posted by GitBox <gi...@apache.org>.
markhildreth edited a comment on pull request #7024:
URL: https://github.com/apache/arrow/pull/7024#issuecomment-620692002
@nevi-me I don't have access to the failure you linked to (on domain `git.data-engine.co.za`, but if you mean the failure showing up in CI, there was a change (https://github.com/apache/arrow/commit/d094631bbb780bc686bebd9a87a0b3e4aa7e0ff0) to that file on master checked in after this branch was created. Rebasing a local branch onto master should cause the error to appear locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] markhildreth commented on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly
Posted by GitBox <gi...@apache.org>.
markhildreth commented on pull request #7024:
URL: https://github.com/apache/arrow/pull/7024#issuecomment-620692002
@nevi-me I don't have access to the failure you linked to (on domain `git.data-engine.co.za`, but if you mean the failure showing up in CI, there was a change to that file on master checked in after this branch was created. Rebasing a local branch onto master should cause the error to appear locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #7024:
URL: https://github.com/apache/arrow/pull/7024#issuecomment-620739497
Thanks @markhildreth, I didn't see that the branch wasn't rebased into master. We should be fine now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org