[GitHub] khos2ow commented on a change in pull request #2762: Make HTTP handler of embedded server to be configured

[GitBox <gi...@apache.org>]

khos2ow commented on a change in pull request #2762: Make HTTP handler of embedded server to be configured
URL: https://github.com/apache/cloudstack/pull/2762#discussion_r204490780
 
 

 ##########
 File path: client/src/main/java/org/apache/cloudstack/ServerDaemon.java
 ##########
 @@ -129,6 +132,11 @@ public void init(final DaemonContext context) {
             setSessionTimeout(Integer.valueOf(properties.getProperty(SESSION_TIMEOUT, "30")));
         } catch (final IOException e) {
             LOG.warn("Failed to load configuration from server.properties file", e);
+        } finally {
+            // make sure that at least HTTP is enabled if both of them are set to false (misconfiguration)
+            if (!httpEnable && !httpsEnable) {
+                setHttpEnable(true);
 
 Review comment:
   Right!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services