You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "Baunsgaard (via GitHub)" <gi...@apache.org> on 2025/02/05 11:55:07 UTC
[PR] [MINOR] Refactor Matrix append [systemds]
Baunsgaard opened a new pull request, #2219:
URL: https://github.com/apache/systemds/pull/2219
This PR contains a refactor of MatrixBlock.append, the refactor serves two purposes.
1. The append logic inside the MatrixBlock, was > 200 lines with many specific functions only for append logic.
2. To allow JIT compilation of the Sparse and Dense appending respectively. The current implementation contained one big method that did not -- in my experiments -- JIT compile ever.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Refactor Matrix append [systemds]
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard closed pull request #2219: [MINOR] Refactor Matrix append
URL: https://github.com/apache/systemds/pull/2219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Refactor Matrix append [systemds]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2219:
URL: https://github.com/apache/systemds/pull/2219#issuecomment-2636935787
## [Codecov](https://app.codecov.io/gh/apache/systemds/pull/2219?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `94.62366%` with `5 lines` in your changes missing coverage. Please review.
> Project coverage is 72.37%. Comparing base [(`5ff6274`)](https://app.codecov.io/gh/apache/systemds/commit/5ff6274788bf4f5c9b42c2e43494c7f99451571c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`8e4598a`)](https://app.codecov.io/gh/apache/systemds/commit/8e4598ae6c7874fb019d69e4120ffb164616238e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 2 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/systemds/pull/2219?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...che/sysds/runtime/matrix/data/LibMatrixAppend.java](https://app.codecov.io/gh/apache/systemds/pull/2219?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fmatrix%2Fdata%2FLibMatrixAppend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvbWF0cml4L2RhdGEvTGliTWF0cml4QXBwZW5kLmphdmE=) | 94.56% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2219 +/- ##
============================================
- Coverage 72.38% 72.37% -0.02%
+ Complexity 45381 45378 -3
============================================
Files 1468 1469 +1
Lines 170802 170810 +8
Branches 33306 33305 -1
============================================
- Hits 123634 123622 -12
- Misses 37762 37782 +20
Partials 9406 9406
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/systemds/pull/2219?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org