You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "shashbha14 (via GitHub)" <gi...@apache.org> on 2026/01/19 12:06:36 UTC

[PR] GH-48853: [Release] Fix bytes to string comparison in download_rc_binaries.py [arrow]

shashbha14 opened a new pull request, #48896:
URL: https://github.com/apache/arrow/pull/48896

   ### Rationale for this change
   The [download_rc_binaries.py](cci:7://file:///c:/Users/ishwet/arrow/dev/release/download_rc_binaries.py:0:0-0:0) script fails with a `TypeError` when a download fails and it tries to check if the error is related to OpenSSL.
   
   ### What changes are included in this PR?
   `subprocess.Popen().communicate()` returns bytes objects, but the code was comparing `stderr` (bytes) with a string `"OpenSSL"`. Changed to use bytes literal `b"OpenSSL"` for proper comparison.
   
   ### Are these changes tested?
   The fix is straightforward - using bytes literal instead of string literal for comparison with bytes object.
   
   ### Are there any user-facing changes?
   No.
   
   Closes #48853


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-48853: [Release] Fix bytes to string comparison in download_rc_binaries.py [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd merged PR #48896:
URL: https://github.com/apache/arrow/pull/48896


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-48853: [Release] Fix bytes to string comparison in download_rc_binaries.py [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #48896:
URL: https://github.com/apache/arrow/pull/48896#issuecomment-3772806549

   After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 7b99930df50bd1963ffdb5e23fe072914cbc50bb.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/60892942521) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org