You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/09 21:23:18 UTC

[GitHub] [arrow] nealrichardson commented on a change in pull request #9969: ARROW-11589: [R] Add methods for modifying Schemas

nealrichardson commented on a change in pull request #9969:
URL: https://github.com/apache/arrow/pull/9969#discussion_r610911514



##########
File path: r/tests/testthat/test-schema.R
##########
@@ -48,6 +47,11 @@ test_that("Schema $GetFieldByName", {
 })
 
 test_that("Schema extract (returns Field)", {
+  # TODO: should this return a Field or the Type?

Review comment:
       Yeah unfortunately I think it has to be Field here, but in the <- methods I tried to support both ways of assigning.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org