You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/19 00:37:36 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10162: [Transaction] Fix transactionMetadata store recover timeout problem.

codelipenghui commented on a change in pull request #10162:
URL: https://github.com/apache/pulsar/pull/10162#discussion_r615484278



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/timeout/TransactionTimeoutTrackerImpl.java
##########
@@ -40,11 +40,10 @@
     private final TripleLongPriorityQueue priorityQueue = new TripleLongPriorityQueue();
     private final long tickTimeMillis;
     private final Clock clock;
-    private Timeout currentTimeout;
+    private volatile Timeout currentTimeout;

Review comment:
       Do we need `volatile` here? Seem it is protected by the `synchronized`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org