You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/15 11:21:50 UTC

[GitHub] [incubator-nuttx] okayserh opened a new pull request, #6078: Stm32f746 audio

okayserh opened a new pull request, #6078:
URL: https://github.com/apache/incubator-nuttx/pull/6078

   ## Summary
   STM32_RCC_DCKCFGR is not defined for the stm32f746, since the stm32f746 has two configuration registers STM32_RCC_DCKCFGR1 and STM32_RCC_DCKCFGR2. Since the LTDC is only affected by clocks steered by
   the first register, I suppose it should be the register to be output. (I assume this to be a C&P error coming from
   stm32f/stm32_ltdc.c, where the definition stems from stm32/hardware/stm32f40xxx_rcc.h.)
   
   ## Impact
   Bug-Fix
   
   ## Testing
   I'm only wondering why I never encountered that compile error before. However, the affected source file seems
   to compile properly after the fix.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] okayserh commented on pull request #6078: Stm32f746 audio

Posted by GitBox <gi...@apache.org>.
okayserh commented on PR #6078:
URL: https://github.com/apache/incubator-nuttx/pull/6078#issuecomment-1100305165

   Happy to do that, when I have figured out how to do it :-). Have circumvented more serious use of git for some time :-/. I'll go through the docs to figure out ...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6078: Stm32f746 audio

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6078:
URL: https://github.com/apache/incubator-nuttx/pull/6078#issuecomment-1100056935

   @okayserh could you drop the last merge patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6078: Stm32f746 audio

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6078:
URL: https://github.com/apache/incubator-nuttx/pull/6078#issuecomment-1100384845

   No. Seems like the merge commit is still present. Let me try it locally. Maybe interactive rebase is needed in case if branch already contains a "merge" commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6078: Stm32f746 audio

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6078:
URL: https://github.com/apache/incubator-nuttx/pull/6078


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6078: Stm32f746 audio

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6078:
URL: https://github.com/apache/incubator-nuttx/pull/6078#issuecomment-1100582501

   @okayserh I rebase your patch on top of apache mainline, please take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] okayserh commented on pull request #6078: Stm32f746 audio

Posted by GitBox <gi...@apache.org>.
okayserh commented on PR #6078:
URL: https://github.com/apache/incubator-nuttx/pull/6078#issuecomment-1100378640

   Thanks for the quick help! I've entered the commands as suggested. Did this do the job?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6078: Stm32f746 audio

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6078:
URL: https://github.com/apache/incubator-nuttx/pull/6078#issuecomment-1100327159

   ```
   git remote add upstream git@github.com:apache/incubator-nuttx.git
   git checkout stm32f746_audio
   git fetch upstream master
   git rebase upstream/master
   git rebase --continue
   git pus -f origin stm32f746_audio
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org