You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Stefan Bodewig <bo...@apache.org> on 2020/06/01 14:57:33 UTC

Re: [commons-compress] branch master updated: minor typos cleanup

On 2020-06-01, <pe...@apache.org> wrote:

> The following commit(s) were added to refs/heads/master by this push:
>      new 42b6aa4  minor typos cleanup
> -     * @throws IllegalArgumentException if the {@link TarArchiveOutputStream#longFileMode} equals
> -     *                                  {@link TarArchiveOutputStream#LONGFILE_ERROR} and the file
> -     *                                  name is too long

why are you removing the javadocs about throwing on long names?

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [commons-compress] branch master updated: minor typos cleanup

Posted by Stefan Bodewig <bo...@apache.org>.
On 2020-06-02, Peter Lee wrote:

> Oops, I was looking the commit and found two @throws
> IllegalArgumentException, and I was thinking this is a duplicated throws
> caused by copy-paste. And I was so much foolish that I deleted it without
> any invesgating into the code. Really sorry about this.

No problem and thank you for fixing it so quickly.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [commons-compress] branch master updated: minor typos cleanup

Posted by Peter Lee <pe...@gmail.com>.
Oops, I was looking the commit and found two @throws
IllegalArgumentException, and I was thinking this is a duplicated throws
caused by copy-paste. And I was so much foolish that I deleted it without
any invesgating into the code. Really sorry about this.

On Mon, Jun 1, 2020 at 10:57 PM Stefan Bodewig <bo...@apache.org> wrote:

> On 2020-06-01, <pe...@apache.org> wrote:
>
> > The following commit(s) were added to refs/heads/master by this push:
> >      new 42b6aa4  minor typos cleanup
> > -     * @throws IllegalArgumentException if the {@link
> TarArchiveOutputStream#longFileMode} equals
> > -     *                                  {@link
> TarArchiveOutputStream#LONGFILE_ERROR} and the file
> > -     *                                  name is too long
>
> why are you removing the javadocs about throwing on long names?
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>