You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Joris van Lieshout <jv...@schubergphilis.com> on 2014/11/08 17:28:21 UTC
Review Request 27775: Absoluut path to scripts in logrotate config
files
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27775/
-----------------------------------------------------------
Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Hugo Trippaers.
Repository: cloudstack-git
Description
-------
Logrotate is called from crontab. Debian crontab does not include everything in it's path. Therefore reference to these bins need to be absoluut.
Diffs
-----
systemvm/patches/debian/config/etc/logrotate.d/cloud 37440ac
systemvm/patches/debian/config/etc/logrotate.d/conntrackd d09d752
systemvm/patches/debian/config/etc/logrotate.d/rsyslog d2a04ca
Diff: https://reviews.apache.org/r/27775/diff/
Testing
-------
We have allready implemented this fix in our own beta and prod environment.
Thanks,
Joris van Lieshout
Re: Review Request 27775: Absoluut path to scripts in logrotate
config files
Posted by daan Hoogland <da...@gmail.com>.
> On Nov. 9, 2014, 12:15 p.m., daan Hoogland wrote:
> > 380ecf2253dd03905df25f30422b67ec1b17ff19 in 4.4
1cc733bfd52e4106bce151ac1c7253b2e4873764 in 4.5
1e1cc11d9ad617df1e53cbc7da658e9987d6cc21 in master
- daan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27775/#review60505
-----------------------------------------------------------
On Nov. 8, 2014, 4:28 p.m., Joris van Lieshout wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27775/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2014, 4:28 p.m.)
>
>
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Logrotate is called from crontab. Debian crontab does not include everything in it's path. Therefore reference to these bins need to be absoluut.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/logrotate.d/cloud 37440ac
> systemvm/patches/debian/config/etc/logrotate.d/conntrackd d09d752
> systemvm/patches/debian/config/etc/logrotate.d/rsyslog d2a04ca
>
> Diff: https://reviews.apache.org/r/27775/diff/
>
>
> Testing
> -------
>
> We have allready implemented this fix in our own beta and prod environment.
>
>
> Thanks,
>
> Joris van Lieshout
>
>
Re: Review Request 27775: Absoluut path to scripts in logrotate
config files
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27775/#review60505
-----------------------------------------------------------
Ship it!
380ecf2253dd03905df25f30422b67ec1b17ff19 in 4.4
- daan Hoogland
On Nov. 8, 2014, 4:28 p.m., Joris van Lieshout wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27775/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2014, 4:28 p.m.)
>
>
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Logrotate is called from crontab. Debian crontab does not include everything in it's path. Therefore reference to these bins need to be absoluut.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/logrotate.d/cloud 37440ac
> systemvm/patches/debian/config/etc/logrotate.d/conntrackd d09d752
> systemvm/patches/debian/config/etc/logrotate.d/rsyslog d2a04ca
>
> Diff: https://reviews.apache.org/r/27775/diff/
>
>
> Testing
> -------
>
> We have allready implemented this fix in our own beta and prod environment.
>
>
> Thanks,
>
> Joris van Lieshout
>
>