You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (JIRA)" <ji...@apache.org> on 2018/06/30 00:33:01 UTC

[jira] [Updated] (CALCITE-2363) Refactor RelShuttle not to depend on structures of RelNodes

     [ https://issues.apache.org/jira/browse/CALCITE-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Hyde updated CALCITE-2363:
---------------------------------
    Fix Version/s: 1.17.0

> Refactor RelShuttle not to depend on structures of RelNodes
> -----------------------------------------------------------
>
>                 Key: CALCITE-2363
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2363
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Teruyoshi Zenmyo
>            Assignee: Julian Hyde
>            Priority: Major
>             Fix For: 1.17.0
>
>
> Currently, RelShuttle implementations depends on the structures of RelNodes.
> For instance, RelShuttleImp.visit(LogicalAggregate aggregate) knows the first element of getInput() is the next element to be visited. 
> [https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/rel/RelShuttleImpl.java#L75]
>  
> By this refactoring, implementations of RelShuttle will become free from invoking super.visit methods.
> https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql2rel/CorrelationReferenceFinder.java#L61



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)