You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/07/24 02:25:56 UTC

Review Request 23873: Add back declaration of stream operator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23873/
-----------------------------------------------------------

Review request for mesos, Isabel Jimenez and Vinod Kone.


Bugs: MESOS-1632
    https://issues.apache.org/jira/browse/MESOS-1632


Repository: mesos-git


Description
-------

in a recent refactor the declaration of the stream operator was lost.


Diffs
-----

  include/mesos/resources.hpp 9f8c594293b9e901a84b89c6812cfe17e94a1f9d 

Diff: https://reviews.apache.org/r/23873/diff/


Testing
-------

tests run


Thanks,

Dominic Hamon


Re: Review Request 23873: Add back declaration of stream operator.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23873/#review48589
-----------------------------------------------------------



include/mesos/resources.hpp
<https://reviews.apache.org/r/23873/#comment85300>

    s/resource/resources


- Jiang Yan Xu


On July 23, 2014, 5:25 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23873/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 5:25 p.m.)
> 
> 
> Review request for mesos, Isabel Jimenez and Vinod Kone.
> 
> 
> Bugs: MESOS-1632
>     https://issues.apache.org/jira/browse/MESOS-1632
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> in a recent refactor the declaration of the stream operator was lost.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 9f8c594293b9e901a84b89c6812cfe17e94a1f9d 
> 
> Diff: https://reviews.apache.org/r/23873/diff/
> 
> 
> Testing
> -------
> 
> tests run
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 23873: Add back declaration of stream operator.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23873/#review48590
-----------------------------------------------------------

Ship it!


Ship It!

- Jiang Yan Xu


On July 23, 2014, 5:29 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23873/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 5:29 p.m.)
> 
> 
> Review request for mesos, Isabel Jimenez and Vinod Kone.
> 
> 
> Bugs: MESOS-1632
>     https://issues.apache.org/jira/browse/MESOS-1632
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> in a recent refactor the declaration of the stream operator was lost.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 9f8c594293b9e901a84b89c6812cfe17e94a1f9d 
> 
> Diff: https://reviews.apache.org/r/23873/diff/
> 
> 
> Testing
> -------
> 
> tests run
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 23873: Add back declaration of stream operator.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23873/
-----------------------------------------------------------

(Updated July 23, 2014, 5:29 p.m.)


Review request for mesos, Isabel Jimenez and Vinod Kone.


Bugs: MESOS-1632
    https://issues.apache.org/jira/browse/MESOS-1632


Repository: mesos-git


Description
-------

in a recent refactor the declaration of the stream operator was lost.


Diffs (updated)
-----

  include/mesos/resources.hpp 9f8c594293b9e901a84b89c6812cfe17e94a1f9d 

Diff: https://reviews.apache.org/r/23873/diff/


Testing
-------

tests run


Thanks,

Dominic Hamon


Re: Review Request 23873: Add back declaration of stream operator.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23873/#review48588
-----------------------------------------------------------

Ship it!



include/mesos/resources.hpp
<https://reviews.apache.org/r/23873/#comment85299>

    2 blank lines to separate outer elements please.


- Vinod Kone


On July 24, 2014, 12:25 a.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23873/
> -----------------------------------------------------------
> 
> (Updated July 24, 2014, 12:25 a.m.)
> 
> 
> Review request for mesos, Isabel Jimenez and Vinod Kone.
> 
> 
> Bugs: MESOS-1632
>     https://issues.apache.org/jira/browse/MESOS-1632
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> in a recent refactor the declaration of the stream operator was lost.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 9f8c594293b9e901a84b89c6812cfe17e94a1f9d 
> 
> Diff: https://reviews.apache.org/r/23873/diff/
> 
> 
> Testing
> -------
> 
> tests run
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 23873: Add back declaration of stream operator.

Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23873/#review48587
-----------------------------------------------------------

Ship it!


Ship It!

- Isabel Jimenez


On July 24, 2014, 12:25 a.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23873/
> -----------------------------------------------------------
> 
> (Updated July 24, 2014, 12:25 a.m.)
> 
> 
> Review request for mesos, Isabel Jimenez and Vinod Kone.
> 
> 
> Bugs: MESOS-1632
>     https://issues.apache.org/jira/browse/MESOS-1632
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> in a recent refactor the declaration of the stream operator was lost.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 9f8c594293b9e901a84b89c6812cfe17e94a1f9d 
> 
> Diff: https://reviews.apache.org/r/23873/diff/
> 
> 
> Testing
> -------
> 
> tests run
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>