You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@roller.apache.org by Allen Gilliland <al...@sun.com> on 2006/06/29 00:14:47 UTC

remove inline edit links on weblog pages?

I know I have brought this up before and I don't remember how it was 
received, but in any case I'm going to bring it up again.  Would anyone 
be opposed to the idea of removing the set of edit links that we embed 
into weblog pages?  I think the reasons to do this are many ...

1. It would *significantly* simplify the page rendering process to not 
have to deal the issue of rendering things differently if the weblog 
owner is logged in.  I believe there is a fair amount of logic that goes 
into the models/macros/rendering to deal with this situation which could 
all be removed.

2. I consider this feature minimally useful.  I don't see why a weblog 
author would browser their site to look for things to edit rather than 
just logging into the "editing" interface and doing their work their.

3. This feature is only ever of benefit to a single person, the weblog 
author.  We add a fair amount of extra logic just so that these pages 
can be rendered to benefit a single person :/

4. This would never work in a statically rendered site.

As far as I am concerned this feature requires way more overhead than 
it's worth.  If we rip it out we simplify a number of things ...

1. we can remove all elements of models and macros which perform any 
logic based on a users login status.  this would simplify a number of 
models and macros.

2. we can simplify our caching because the cache no longer needs to know 
if the user is logged in or not and render/cache those pages separately. 
  this reduces the size of the cache (possibly significantly on large 
sites) and eliminates unnecessary redundancy.

So, my opinion is pretty obvious.  I think this is a feature which can 
safely be removed and will do some very good things to simplify a number 
of aspects of weblog rendering.

Thoughts?  Opinions?

-- Allen