You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2018/10/11 21:40:41 UTC
[kudu-CR] ksck: quell build warning
Hello Will Berkeley,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11661
to review the following change.
Change subject: ksck: quell build warning
......................................................................
ksck: quell build warning
Was seeing:
../../src/kudu/tools/ksck_checksum.cc:677:1: warning: control reaches end of non-void function [-Wreturn-type]
Change-Id: I696ff790111cc0b371dbb762a3c5167d834136f7
---
M src/kudu/tools/ksck_checksum.cc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/11661/1
--
To view, visit http://gerrit.cloudera.org:8080/11661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I696ff790111cc0b371dbb762a3c5167d834136f7
Gerrit-Change-Number: 11661
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] ksck: quell build warning
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11661 )
Change subject: ksck: quell build warning
......................................................................
ksck: quell build warning
Was seeing:
../../src/kudu/tools/ksck_checksum.cc:677:1: warning: control reaches end of non-void function [-Wreturn-type]
Change-Id: I696ff790111cc0b371dbb762a3c5167d834136f7
Reviewed-on: http://gerrit.cloudera.org:8080/11661
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Kudu Jenkins
---
M src/kudu/tools/ksck_checksum.cc
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Will Berkeley: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I696ff790111cc0b371dbb762a3c5167d834136f7
Gerrit-Change-Number: 11661
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] ksck: quell build warning
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11661
to look at the new patch set (#2).
Change subject: ksck: quell build warning
......................................................................
ksck: quell build warning
Was seeing:
../../src/kudu/tools/ksck_checksum.cc:677:1: warning: control reaches end of non-void function [-Wreturn-type]
Change-Id: I696ff790111cc0b371dbb762a3c5167d834136f7
---
M src/kudu/tools/ksck_checksum.cc
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/11661/2
--
To view, visit http://gerrit.cloudera.org:8080/11661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I696ff790111cc0b371dbb762a3c5167d834136f7
Gerrit-Change-Number: 11661
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] ksck: quell build warning
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11661 )
Change subject: ksck: quell build warning
......................................................................
Patch Set 2: Code-Review+2
Are you sure LOG_FATAL doesn't cause the warning to be suppressed without the return? My memory is that it would.
--
To view, visit http://gerrit.cloudera.org:8080/11661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I696ff790111cc0b371dbb762a3c5167d834136f7
Gerrit-Change-Number: 11661
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 22:21:28 +0000
Gerrit-HasComments: No
[kudu-CR] ksck: quell build warning
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11661 )
Change subject: ksck: quell build warning
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11661/1/src/kudu/tools/ksck_checksum.cc
File src/kudu/tools/ksck_checksum.cc:
http://gerrit.cloudera.org:8080/#/c/11661/1/src/kudu/tools/ksck_checksum.cc@677
PS1, Line 677: return Status::OK();
Our compiler can't figure out that is unreachable? It should be, so maybe LOG_FATAL instead.
--
To view, visit http://gerrit.cloudera.org:8080/11661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I696ff790111cc0b371dbb762a3c5167d834136f7
Gerrit-Change-Number: 11661
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 22:00:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] ksck: quell build warning
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11661 )
Change subject: ksck: quell build warning
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11661/1/src/kudu/tools/ksck_checksum.cc
File src/kudu/tools/ksck_checksum.cc:
http://gerrit.cloudera.org:8080/#/c/11661/1/src/kudu/tools/ksck_checksum.cc@677
PS1, Line 677: LOG(FATAL) << "Reach
> Our compiler can't figure out that is unreachable? It should be, so maybe L
Alas, indeed.
--
To view, visit http://gerrit.cloudera.org:8080/11661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I696ff790111cc0b371dbb762a3c5167d834136f7
Gerrit-Change-Number: 11661
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 22:15:38 +0000
Gerrit-HasComments: Yes