You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/09/08 16:12:48 UTC

[GitHub] [hadoop] brumi1024 commented on pull request #3360: YARN-10909. AbstractCSQueue: add @VisibleForTesting annotation for test code

brumi1024 commented on pull request #3360:
URL: https://github.com/apache/hadoop/pull/3360#issuecomment-915375829


   @JackWangCS, my mistake, sorry, mixed it up with another method. I have one small nit: getLastSubmittedTimestamp and setLastSubmittedTimestamp is now package private, but updateLastSubmittedTimeStamp is public and they operate on the same variable. Can you please change it as well? Otherwise +1 from my side.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org