You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Jan Piotrowski (Sujan) (JIRA)" <ji...@apache.org> on 2018/11/26 15:23:00 UTC

[jira] [Resolved] (CB-10958) scripts/after_install.js overwrites content @src attribute

     [ https://issues.apache.org/jira/browse/CB-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Piotrowski (Sujan) resolved CB-10958.
-----------------------------------------
    Resolution: Fixed

PR was merged long time ago.

> scripts/after_install.js overwrites content @src attribute
> ----------------------------------------------------------
>
>                 Key: CB-10958
>                 URL: https://issues.apache.org/jira/browse/CB-10958
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-labs
>            Reporter: Andreas Kohn
>            Priority: Major
>              Labels: triaged
>
> The scripts/after_install.js script of the cordova-labs-local-webserver overwrites the 'src' attribute of the 'content' element when it is executed, always setting the port to '0' (randomised).
> This might be fine if one is working with the environment on a single checkout on a single machine, where one merely has to modify the file afterwards; it might also be fine when one opts to commit the platforms/ and plugins/ directories to source control.
> This doesn't seem a proper behaviour or assumption though: For example, in our environment we use the https://github.com/SamVerschueren/gulp-cordova plugins to produce a reproducible state as part of the integration build. A workaround would be to post-process the config.xml and restore the port we need, but it is fairly easy to fix in the cordoba-labs-local-webserver plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org