[GitHub] [trafficcontrol] ocket8888 commented on issue #3739: TP: adds the ability to rearrange delivery service table columns as well as toggle column visibility/searchability

[GitBox <gi...@apache.org>]

ocket8888 commented on issue #3739: TP: adds the ability to rearrange delivery service table columns as well as toggle column visibility/searchability
URL: https://github.com/apache/trafficcontrol/pull/3739#issuecomment-516075577
 
 
   So you can now add enough columns that the size of the table becomes greater than the size of the page - and there's nothing you can really do to avoid it without removing functionality. But the problem is that the scrolling looks kinda funky. Check this out:
   
   ![image](https://user-images.githubusercontent.com/6013378/62066787-60bfe680-b1ef-11e9-9b57-7c654ee879b1.png)
   
   That's not really even close to as long as the table could potentially get, and you can see I'm already leaving alerts, pagination/search/utility controls, and even part of the sidebar behind. But another problem is just how long this menu is. Look at this:
   
   ![image](https://user-images.githubusercontent.com/6013378/62066919-beecc980-b1ef-11e9-98c3-a23e44a0496b.png)
   
   You can see that I've managed to pull the sidebar apart, and left my table behind completely, so that if I want to see the effects of adding/removing a column I have to scroll up a bunch. To fix that, I'd recommend setting a max-height on the column selection menu and just scrolling on that instead of the page.
   
   Fixing the first problem, though, isn't quite as trivial. You could either mess with the theme template to try to get the sidebar pinned (e.g. with `position: absolute`) so that you don't leave only parts of it behind or make the bottom part go away with the rest of it. If you choose the first option, you're also probably going to want to find a way to pin the breadcrumbs/title along with it. Either way, the menu and pagination controls can either be pinned to always be on the screen, or pinned to the far right side of the table as it grows.
   
   Alternatively, you could set a max-width on the table and just scroll on that instead of the page.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services