You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Stephane Nicoll (JIRA)" <ji...@apache.org> on 2017/05/11 12:00:09 UTC
[jira] [Comment Edited] (CAMEL-11247) camel-spring-boot - Improve
BOM to work better with start.spring.io
[ https://issues.apache.org/jira/browse/CAMEL-11247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006295#comment-16006295 ]
Stephane Nicoll edited comment on CAMEL-11247 at 5/11/17 12:00 PM:
-------------------------------------------------------------------
[~nferraro] it is a shame that you didn't report that issue. Turns out someone else did and we fixed the jetty dependency management. If that ever happens in the future, please report the issue to us.
I don't think my remark about the fact this request has _nothing_ to do with Spring (or start.spring.io) has been taken into account. What you call {{camel-spring-boot-bom}} is actually {{camel-bom}} in my book, i.e. the list of modules that camel provides.
Also, {{project.version}} is wrong IMO. When you import the camel bom version X.Y.Z, you should see X.Y.Z and not a variable that makes you think it can be overridden. It can't and it shouldn't.
I am also a bit suspicious about that dependency you've added in the bom there. And that bom should contain _all_ artifacts that Camel publishes for a given version.
Finally, the parent looks wrong to me. A published BOM shouldn't define all those properties (I am talking about the things in {{camel-spring-boot-dm}}. Ideally a BOM is parentless.
Let me know if you have any question.
was (Author: snicoll):
[~nferraro] it is a shame that you didn't report that issue. Turns out someone else did and we fixed the jetty dependency management. If that ever happens in the future, please report the issue to us.
I don't think my remark about the fact this request has _nothing_ to do with Spring (or start.spring.io) has been taken into account. What you call {{camel-spring-boot-bom}} is actually {{camel-bom}} in my book, i.e. the list of modules that camel provides.
Also, {{project.version}} is wrong IMO. When you import the camel bom version X.Y.Z, you should see X.Y.Z and not a variable that makes you think it can be overridden. It can't and it shouldn't.
I am also a bit suspicious about that dependency you've added in the bom there. And that bom should contain _all_ artifacts that Camel publishes for a given version.
Let me know if you have any question.
> camel-spring-boot - Improve BOM to work better with start.spring.io
> -------------------------------------------------------------------
>
> Key: CAMEL-11247
> URL: https://issues.apache.org/jira/browse/CAMEL-11247
> Project: Camel
> Issue Type: Improvement
> Components: camel-spring-boot, camel-spring-boot-starters
> Reporter: Claus Ibsen
> Assignee: Nicola Ferraro
> Fix For: 2.20.0
>
>
> See this PR
> https://github.com/spring-io/initializr/pull/425#issuecomment-299801788
> I tried locally to set the initializer to use our current BOM for spring-boot starters, but the project it generates causes the mvn to not build.
> We should IMHO try to get this working so we can use a BOM in the start.spring.io wizard so people get a nicer project build out of the box. Which is also what the Spring guys is asking for.
> You can try the initializer locally, by following instructions at
> https://github.com/spring-io/initializr#running-the-app-locally
> Then you can thinker in the yml file to setup a Camel BOM
> https://github.com/spring-io/initializr/blob/master/initializr-service/src/main/resources/application.yml
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)