[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #4588: Spark: Add custom metric for number of deletes applied by a SparkScan

[GitBox <gi...@apache.org>]

RussellSpitzer commented on code in PR #4588:
URL: https://github.com/apache/iceberg/pull/4588#discussion_r887303132


##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -54,35 +56,42 @@
 import org.apache.iceberg.util.Filter;
 import org.apache.iceberg.util.StructLikeSet;
 import org.apache.iceberg.util.StructProjection;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public abstract class DeleteFilter<T> {
-  private static final long DEFAULT_SET_FILTER_THRESHOLD = 100_000L;
+  private static final Logger LOG = LoggerFactory.getLogger(DeleteFilter.class);
+  public static final long DEFAULT_STREAM_FILTER_THRESHOLD = 100_000L;

Review Comment:
   Can we extract all of these set/streamFilter changes out into another PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org