You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/12/07 15:09:08 UTC
[GitHub] [iotdb] asdf2014 opened a new pull request #2209: Avoid overflow by converting to long
asdf2014 opened a new pull request #2209:
URL: https://github.com/apache/iotdb/pull/2209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #2209: Avoid overflow by converting to long
Posted by GitBox <gi...@apache.org>.
JackieTien97 merged pull request #2209:
URL: https://github.com/apache/iotdb/pull/2209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #2209: Avoid overflow by converting to long
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #2209:
URL: https://github.com/apache/iotdb/pull/2209#discussion_r541521987
##########
File path: server/src/main/java/org/apache/iotdb/db/utils/datastructure/TVList.java
##########
@@ -82,11 +82,9 @@ public static TVList newList(TSDataType dataType) {
public static long tvListArrayMemSize(TSDataType type) {
long size = 0;
// time size
- size +=
- PrimitiveArrayManager.ARRAY_SIZE * 8;
+ size += (long) PrimitiveArrayManager.ARRAY_SIZE * 8L;
Review comment:
Hi, is this really needed?
I think `PrimitiveArrayManager.ARRAY_SIZE * 8` is far less than Integer.MAX_VALUE.
(even the overflow may occurs, just changing `8` to `8L` is fine, right?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2209: Avoid overflow by converting to long
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2209:
URL: https://github.com/apache/iotdb/pull/2209#issuecomment-740000564
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2209&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2209&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2209&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2209&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2209&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2209&resolved=false&types=VULNERABILITY)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2209&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2209&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2209&resolved=false&types=SECURITY_HOTSPOT)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2209&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2209&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2209&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2209) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2209&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2209&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #2209: Avoid overflow by converting to long
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #2209:
URL: https://github.com/apache/iotdb/pull/2209#discussion_r541521987
##########
File path: server/src/main/java/org/apache/iotdb/db/utils/datastructure/TVList.java
##########
@@ -82,11 +82,9 @@ public static TVList newList(TSDataType dataType) {
public static long tvListArrayMemSize(TSDataType type) {
long size = 0;
// time size
- size +=
- PrimitiveArrayManager.ARRAY_SIZE * 8;
+ size += (long) PrimitiveArrayManager.ARRAY_SIZE * 8L;
Review comment:
Hi, is this really needed?
I think `PrimitiveArrayManager.ARRAY_SIZE * 8` is far less than Integer.MAX_VALUE.
(even the overflow may occur, just changing `8` to `8L` is fine, right?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org