You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whimsical.apache.org by Craig Russell <ap...@gmail.com> on 2018/01/12 22:46:19 UTC
A few issues with project/icla/discuss
I've roughed in the discuss page and it has a few issues that I can't figure out.
1. The discussBody field doesn't quite work. Initially the focus should be in the field but I think there is some code missing.
2. The discussBody form doesn't seem to set the @discussBody field. I have a bit of debugging and the variable never is set.
3. The Submit comment button never enables. It should enable when the discussBody field is set to non-null.
4. The \n in the discuss comments show up as is. How do I get control characters like \n to behave?
Any comments on the bugs or on the form design or implementation are welcome.
Craig L Russell
Secretary, Apache Software Foundation
clr@apache.org http://db.apache.org/jdo
Re: A few issues with project/icla/discuss
Posted by Craig Russell <ap...@gmail.com>.
> On Jan 12, 2018, at 3:37 PM, Sam Ruby <ru...@intertwingly.net> wrote:
>
> On Fri, Jan 12, 2018 at 5:46 PM, Craig Russell <ap...@gmail.com> wrote:
>> I've roughed in the discuss page and it has a few issues that I can't figure out.
>>
>> 1. The discussBody field doesn't quite work. Initially the focus should be in the field but I think there is some code missing.
>
> document.getElementById("discussBody").focus()
>
> This requires an element to be defined with an id attribute with a
> value of discussBody. This either can be done by adding
>
> id: 'discussBody'
>
> or adding .discussBody!, thus: _textarea.form_control.discussBody!
>
> Note: in this one, the javascript console is your friend.
Right. fixed.
>
>> 2. The discussBody form doesn't seem to set the @discussBody field. I have a bit of debugging and the variable never is set.
>
> Changing "onChange" to "onInput" will fix this:
>
> https://developer.mozilla.org/en-US/docs/Web/Events/change
> https://developer.mozilla.org/en-US/docs/Web/Events/input
>
> Note: this may have been a holdover from the original React.js
> implementation, which defines its own events. Vue.js uses the
> standard browsers event.
>
> Also, I've seen cases where early errors (such as the one
> getElementById one above) prevents the code getting to the point where
> it adds the event handlers.
This problem went away with the fix to #1.
>
>> 3. The Submit comment button never enables. It should enable when the discussBody field is set to non-null.
>
> Fixed by the above two changes.
And this went away also.
>
>> 4. The \n in the discuss comments show up as is. How do I get control characters like \n to behave?
>
> Try double quotes here: 'We could do better\nMuch better'
>
> See: https://docs.ruby-lang.org/en/2.0.0/syntax/literals_rdoc.html#label-Strings
I tried double quotes and I think the \n is now properly constructed but it doesn't display. The \n is treated as white space.
I can enter multiple lines into the text area but I also want to preserve these line breaks for later display.
Craig
>
>> Any comments on the bugs or on the form design or implementation are welcome.
>>
>> Craig L Russell
>> Secretary, Apache Software Foundation
>> clr@apache.org http://db.apache.org/jdo
>
> - Sam Ruby
Craig L Russell
Secretary, Apache Software Foundation
clr@apache.org http://db.apache.org/jdo
Re: A few issues with project/icla/discuss
Posted by Sam Ruby <ru...@intertwingly.net>.
On Fri, Jan 12, 2018 at 5:46 PM, Craig Russell <ap...@gmail.com> wrote:
> I've roughed in the discuss page and it has a few issues that I can't figure out.
>
> 1. The discussBody field doesn't quite work. Initially the focus should be in the field but I think there is some code missing.
document.getElementById("discussBody").focus()
This requires an element to be defined with an id attribute with a
value of discussBody. This either can be done by adding
id: 'discussBody'
or adding .discussBody!, thus: _textarea.form_control.discussBody!
Note: in this one, the javascript console is your friend.
> 2. The discussBody form doesn't seem to set the @discussBody field. I have a bit of debugging and the variable never is set.
Changing "onChange" to "onInput" will fix this:
https://developer.mozilla.org/en-US/docs/Web/Events/change
https://developer.mozilla.org/en-US/docs/Web/Events/input
Note: this may have been a holdover from the original React.js
implementation, which defines its own events. Vue.js uses the
standard browsers event.
Also, I've seen cases where early errors (such as the one
getElementById one above) prevents the code getting to the point where
it adds the event handlers.
> 3. The Submit comment button never enables. It should enable when the discussBody field is set to non-null.
Fixed by the above two changes.
> 4. The \n in the discuss comments show up as is. How do I get control characters like \n to behave?
Try double quotes here: 'We could do better\nMuch better'
See: https://docs.ruby-lang.org/en/2.0.0/syntax/literals_rdoc.html#label-Strings
> Any comments on the bugs or on the form design or implementation are welcome.
>
> Craig L Russell
> Secretary, Apache Software Foundation
> clr@apache.org http://db.apache.org/jdo
- Sam Ruby