You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/06/24 15:15:02 UTC

[GitHub] [logging-log4j2] vy commented on a change in pull request #528: Bugfix for LOG4J2-3107: SmtpManager.createManagerName ignores port

vy commented on a change in pull request #528:
URL: https://github.com/apache/logging-log4j2/pull/528#discussion_r658042296



##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/net/SmtpManager.java
##########
@@ -166,9 +172,7 @@ private static String createManagerName(
         sb.append(isDebug ? ":debug:" : "::");
         sb.append(filterName);
 
-        final String hash = NameUtil.md5(sb.toString());
-        return "SMTP:" + hash;
-
+        return "SMTP:" + sb.toString();

Review comment:
       Given `password` is in `sb`, this is not a good idea. Would you mind reverting this line, please?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org