You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/08/19 12:06:37 UTC
[GitHub] [incubator-pekko-persistence-r2dbc] pjfanning opened a new pull request, #52: scala3 support for core module
pjfanning opened a new pull request, #52:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/52
* migration and projection modules need pekko-persistence-jdbc scala3 support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] He-Pin commented on a diff in pull request #52: scala3 support for core module
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #52:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/52#discussion_r1313418561
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/query/scaladsl/QueryDao.scala:
##########
@@ -179,10 +179,10 @@ private[r2dbc] class QueryDao(settings: R2dbcSettings, connectionFactory: Connec
row =>
if (backtracking)
SerializedJournalRow(
- slice = row.get("slice", classOf[Integer]),
+ slice = row.get[Integer]("slice", classOf[Integer]),
Review Comment:
Yes, I was expect Scala3 has better type inference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] pjfanning commented on a diff in pull request #52: scala3 support for core module
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #52:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/52#discussion_r1313267062
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/query/scaladsl/QueryDao.scala:
##########
@@ -179,10 +179,10 @@ private[r2dbc] class QueryDao(settings: R2dbcSettings, connectionFactory: Connec
row =>
if (backtracking)
SerializedJournalRow(
- slice = row.get("slice", classOf[Integer]),
+ slice = row.get[Integer]("slice", classOf[Integer]),
Review Comment:
I don't know. Scala 3 is not Scala 2 and does not work excatly the same as Scala 2. The code does not work in Scala 3 if I do not add this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] He-Pin commented on a diff in pull request #52: scala3 support for core module
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #52:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/52#discussion_r1313245808
##########
.github/workflows/build-test.yml:
##########
@@ -36,6 +36,30 @@ jobs:
- name: Compile and test for JDK ${{ matrix.JAVA_VERSION }}, Scala ${{ matrix.SCALA_VERSION }}
run: sbt ++${{ matrix.SCALA_VERSION }} test:compile
+ compile3:
+ name: Test and compile (scala 3)
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+
+ - name: Setup Java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: temurin
+ java-version: 8
+
+ - name: Cache Coursier cache
+ uses: coursier/cache-action@v6
+
+ - name: Enable jvm-opts
+ run: cp .jvmopts-ci .jvmopts
+
+ - name: Compile
+ run: sbt ++3.3.0 core/Test/compile
Review Comment:
`sbt ++3.3.x` https://github.com/sbt/sbt/pull/6936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] pjfanning merged pull request #52: scala3 support for core module
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #52:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] pjfanning commented on a diff in pull request #52: scala3 support for core module
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #52:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/52#discussion_r1313267062
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/query/scaladsl/QueryDao.scala:
##########
@@ -179,10 +179,10 @@ private[r2dbc] class QueryDao(settings: R2dbcSettings, connectionFactory: Connec
row =>
if (backtracking)
SerializedJournalRow(
- slice = row.get("slice", classOf[Integer]),
+ slice = row.get[Integer]("slice", classOf[Integer]),
Review Comment:
I don't know. Scala 3 is not Scala 2 and does not work exactly the same as Scala 2. The code does not work in Scala 3 if I do not add this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] He-Pin commented on a diff in pull request #52: scala3 support for core module
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #52:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/52#discussion_r1313263068
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/query/scaladsl/QueryDao.scala:
##########
@@ -179,10 +179,10 @@ private[r2dbc] class QueryDao(settings: R2dbcSettings, connectionFactory: Connec
row =>
if (backtracking)
SerializedJournalRow(
- slice = row.get("slice", classOf[Integer]),
+ slice = row.get[Integer]("slice", classOf[Integer]),
Review Comment:
Why scala3 can't infer this type info?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org