[jira] [Closed] (OFBIZ-5257) Method isInvoiceInForeignCurrency in InvoiceServices.xml is named wrong

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-5257.
----------------------------------

    Resolution: Not A Problem
      Assignee: Hans Bakker

I agree with Hans, using is or has, etc. is our convention (Java community at large) for methods with boolean result. You will find hundreds of examples in Java code, same applies for simple-methods. There are few cases of check but those are more exceptions in my eyes or related to a specific context, like in EE.

If not convincedf Google (or for me use DuckDuckGo) for "java naming boolean method".

> Method isInvoiceInForeignCurrency in InvoiceServices.xml is named wrong
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-5257
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5257
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Pierre Smits
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-5257-ACCTG-WrongMethodNaming.patch
>
>
> The name of this method in accounting services doesn't tell what it does. 
> You have to go into the description what the functionality of the method is, namely checking whether an invoice is a foreign currency.
> Best practice is to have the name of the function reflect the functionality.



--
This message was sent by Atlassian JIRA
(v6.1#6144)