You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by Avik Sengupta <av...@itellix.com> on 2005/04/20 14:32:19 UTC
o.a.pi.poifs.filesystem.TestEmptyDocument fails on HEAD
with the following error. Ideas?? Can someone confirm this with latest
CVS HEAD?
(ant -Dtestcase=org.apache.poi.poifs.filesystem.TestEmptyDocument
single-test)
[junit] Testcase: testSingleEmptyDocument took 0.113 sec
[junit] Caused an ERROR
[junit] Cannot remove block[ 0 ]; out of range
[junit] java.io.IOException: Cannot remove block[ 0 ]; out of range
[junit] at
org.apache.poi.poifs.storage.BlockListImpl.remove(BlockListImpl.java:103)
[junit] at
org.apache.poi.poifs.storage.BlockAllocationTableReader.fetchBlocks(BlockAllocationTableReader.java:190)
[junit] at
org.apache.poi.poifs.storage.BlockListImpl.fetchBlocks(BlockListImpl.java:128)
[junit] at
org.apache.poi.poifs.filesystem.POIFSFileSystem.processProperties(POIFSFileSystem.java:403)
[junit] at
org.apache.poi.poifs.filesystem.POIFSFileSystem.<init>(POIFSFileSystem.java:102)
[junit] at
org.apache.poi.poifs.filesystem.TestEmptyDocument.testSingleEmptyDocument(TestEmptyDocument.java:94)
--
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
Re: o.a.pi.poifs.filesystem.TestEmptyDocument fails on HEAD
Posted by Rainer Klute <kl...@rainer-klute.de>.
Am Freitag, den 22.04.2005, 11:46 +0530 schrieb Avik Sengupta:
> And we've seen that happen to POI in the last year that we've had
> breakage in HEAD.. it really affects development velocity when you cant
> answer the above question confidently!
>
> I've tried to find a middle path in the current build.xml that i just
> checked in .
Oh, well, this is probably the best we can do today. Thanks!
Best regards
Rainer Klute
Rainer Klute IT-Consulting GmbH
Dipl.-Inform.
Rainer Klute E-Mail: klute@rainer-klute.de
Körner Grund 24 Telefon: +49 172 2324824
D-44143 Dortmund Telefax: +49 231 5349423
Inhibit software patents: http://www.nosoftwarepatents.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
Re: o.a.pi.poifs.filesystem.TestEmptyDocument fails on HEAD
Posted by Avik Sengupta <av...@itellix.com>.
>Instead someone should fix the bugs.
Well, yes, that is ideal.. but if that doesnt happen, then you are left
with the possibility that regressions get into the codebase when people
cant answer "Do all tests that are SUPPOSED TO PASS, continue to pass
after my fix?"
And we've seen that happen to POI in the last year that we've had
breakage in HEAD.. it really affects development velocity when you cant
answer the above question confidently!
I've tried to find a middle path in the current build.xml that i just
checked in .
Regards
-
Avik
On Wed, 2005-04-20 at 22:36 +0200, Rainer Klute wrote:
> Am Mittwoch, den 20.04.2005, 23:17 +0530 schrieb
> Avik.sengupta@itellix.com:
> > Ok, thanks. That makes sense. Do you have a bug he for this? I'll update the code with that. In any event i think we should not run known failing tests by default, it can hide other breakage. I've been thinking of a way to keep them separately in cvs; for now i'll disable them.Quoting Rainer Klute <kl...@rainer-klute.de>:
>
> Its bug 11744. However, I think we should never leave out any testcases!
> Omitting failing testcases contradicts the whole sense of testing.
> Instead someone should fix the bugs.
>
> Best regards
> Rainer Klute
>
> Rainer Klute IT-Consulting GmbH
> Dipl.-Inform.
> Rainer Klute E-Mail: klute@rainer-klute.de
> Körner Grund 24 Telefon: +49 172 2324824
> D-44143 Dortmund Telefax: +49 231 5349423
>
> Inhibit software patents: http://www.nosoftwarepatents.com/
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> Mailing List: http://jakarta.apache.org/site/mail2.html#poi
> The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
>
--
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
Re: o.a.pi.poifs.filesystem.TestEmptyDocument fails on HEAD
Posted by Rainer Klute <kl...@rainer-klute.de>.
Am Mittwoch, den 20.04.2005, 23:17 +0530 schrieb
Avik.sengupta@itellix.com:
> Ok, thanks. That makes sense. Do you have a bug he for this? I'll update the code with that. In any event i think we should not run known failing tests by default, it can hide other breakage. I've been thinking of a way to keep them separately in cvs; for now i'll disable them.Quoting Rainer Klute <kl...@rainer-klute.de>:
Its bug 11744. However, I think we should never leave out any testcases!
Omitting failing testcases contradicts the whole sense of testing.
Instead someone should fix the bugs.
Best regards
Rainer Klute
Rainer Klute IT-Consulting GmbH
Dipl.-Inform.
Rainer Klute E-Mail: klute@rainer-klute.de
Körner Grund 24 Telefon: +49 172 2324824
D-44143 Dortmund Telefax: +49 231 5349423
Inhibit software patents: http://www.nosoftwarepatents.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
Re: o.a.pi.poifs.filesystem.TestEmptyDocument fails on HEAD
Posted by Av...@itellix.com.
Ok, thanks. That makes sense. Do you have a bug he for this? I'll update the code with that. In any event i think we should not run known failing tests by default, it can hide other breakage. I've been thinking of a way to keep them separately in cvs; for now i'll disable them.Quoting Rainer Klute <kl...@rainer-klute.de>:
> Avik,
>
> this testcase never ran successfully. I added it once because someone
> sent an error report and complained that reading an empty document does
> not work. The testcase verifies that by creating an empty document and
> trying to read it back in.
>
> I fiddeled around with POIFS a little bit but due to lack of time and
> lack of knowledge about POIFS I couldn't find a solution. However, I
> believe that this is an error and someone who knows POIFS better than me
> should try to solve that issue.
>
> Am Mittwoch, den 20.04.2005, 18:02 +0530 schrieb Avik Sengupta:
>> with the following error. Ideas?? Can someone confirm this with latest
>> CVS HEAD?
>> (ant -Dtestcase=org.apache.poi.poifs.filesystem.TestEmptyDocument
>> single-test)
>>
>> [junit] Testcase: testSingleEmptyDocument took 0.113 sec
>> [junit] Caused an ERROR
>> [junit] Cannot remove block[ 0 ]; out of range
>> [junit] java.io.IOException: Cannot remove block[ 0 ]; out of range
>> [junit] at
>> org.apache.poi.poifs.storage.BlockListImpl.remove(BlockListImpl.java:103)
>> [junit] at
>> org.apache.poi.poifs.storage.BlockAllocationTableReader.fetchBlocks(BlockAllocationTableReader.java:190)
>> [junit] at
>> org.apache.poi.poifs.storage.BlockListImpl.fetchBlocks(BlockListImpl.java:128)
>> [junit] at
>> org.apache.poi.poifs.filesystem.POIFSFileSystem.processProperties(POIFSFileSystem.java:403)
>> [junit] at
>> org.apache.poi.poifs.filesystem.POIFSFileSystem.<init>(POIFSFileSystem.java:102)
>> [junit] at
>> org.apache.poi.poifs.filesystem.TestEmptyDocument.testSingleEmptyDocument(TestEmptyDocument.java:94)
>
> Best regards
> Rainer Klute
>
> Rainer Klute IT-Consulting GmbH
> Dipl.-Inform.
> Rainer Klute E-Mail: klute@rainer-klute.de
> K�rner Grund 24 Telefon: +49 172 2324824
> D-44143 Dortmund Telefax: +49 231 5349423
>
> Inhibit software patents: http://www.nosoftwarepatents.com/
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> Mailing List: http://jakarta.apache.org/site/mail2.html#poi
> The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
Re: o.a.pi.poifs.filesystem.TestEmptyDocument fails on HEAD
Posted by Av...@itellix.com.
Ok, thanks. That makes sense. Do you have a bug he for this? I'll update the code with that. In any event i think we should not run known failing tests by default, it can hide other breakage. I've been thinking of a way to keep them separately in cvs; for now i'll disable them.Quoting Rainer Klute <kl...@rainer-klute.de>:
> Avik,
>
> this testcase never ran successfully. I added it once because someone
> sent an error report and complained that reading an empty document does
> not work. The testcase verifies that by creating an empty document and
> trying to read it back in.
>
> I fiddeled around with POIFS a little bit but due to lack of time and
> lack of knowledge about POIFS I couldn't find a solution. However, I
> believe that this is an error and someone who knows POIFS better than me
> should try to solve that issue.
>
> Am Mittwoch, den 20.04.2005, 18:02 +0530 schrieb Avik Sengupta:
>> with the following error. Ideas?? Can someone confirm this with latest
>> CVS HEAD?
>> (ant -Dtestcase=org.apache.poi.poifs.filesystem.TestEmptyDocument
>> single-test)
>>
>> [junit] Testcase: testSingleEmptyDocument took 0.113 sec
>> [junit] Caused an ERROR
>> [junit] Cannot remove block[ 0 ]; out of range
>> [junit] java.io.IOException: Cannot remove block[ 0 ]; out of range
>> [junit] at
>> org.apache.poi.poifs.storage.BlockListImpl.remove(BlockListImpl.java:103)
>> [junit] at
>> org.apache.poi.poifs.storage.BlockAllocationTableReader.fetchBlocks(BlockAllocationTableReader.java:190)
>> [junit] at
>> org.apache.poi.poifs.storage.BlockListImpl.fetchBlocks(BlockListImpl.java:128)
>> [junit] at
>> org.apache.poi.poifs.filesystem.POIFSFileSystem.processProperties(POIFSFileSystem.java:403)
>> [junit] at
>> org.apache.poi.poifs.filesystem.POIFSFileSystem.<init>(POIFSFileSystem.java:102)
>> [junit] at
>> org.apache.poi.poifs.filesystem.TestEmptyDocument.testSingleEmptyDocument(TestEmptyDocument.java:94)
>
> Best regards
> Rainer Klute
>
> Rainer Klute IT-Consulting GmbH
> Dipl.-Inform.
> Rainer Klute E-Mail: klute@rainer-klute.de
> K�rner Grund 24 Telefon: +49 172 2324824
> D-44143 Dortmund Telefax: +49 231 5349423
>
> Inhibit software patents: http://www.nosoftwarepatents.com/
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> Mailing List: http://jakarta.apache.org/site/mail2.html#poi
> The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
Re: o.a.pi.poifs.filesystem.TestEmptyDocument fails on HEAD
Posted by Av...@itellix.com.
Ok, thanks. That makes sense. Do you have a bug he for this? I'll update the code with that. In any event i think we should not run known failing tests by default, it can hide other breakage. I've been thinking of a way to keep them separately in cvs; for now i'll disable them.Quoting Rainer Klute <kl...@rainer-klute.de>:
> Avik,
>
> this testcase never ran successfully. I added it once because someone
> sent an error report and complained that reading an empty document does
> not work. The testcase verifies that by creating an empty document and
> trying to read it back in.
>
> I fiddeled around with POIFS a little bit but due to lack of time and
> lack of knowledge about POIFS I couldn't find a solution. However, I
> believe that this is an error and someone who knows POIFS better than me
> should try to solve that issue.
>
> Am Mittwoch, den 20.04.2005, 18:02 +0530 schrieb Avik Sengupta:
>> with the following error. Ideas?? Can someone confirm this with latest
>> CVS HEAD?
>> (ant -Dtestcase=org.apache.poi.poifs.filesystem.TestEmptyDocument
>> single-test)
>>
>> [junit] Testcase: testSingleEmptyDocument took 0.113 sec
>> [junit] Caused an ERROR
>> [junit] Cannot remove block[ 0 ]; out of range
>> [junit] java.io.IOException: Cannot remove block[ 0 ]; out of range
>> [junit] at
>> org.apache.poi.poifs.storage.BlockListImpl.remove(BlockListImpl.java:103)
>> [junit] at
>> org.apache.poi.poifs.storage.BlockAllocationTableReader.fetchBlocks(BlockAllocationTableReader.java:190)
>> [junit] at
>> org.apache.poi.poifs.storage.BlockListImpl.fetchBlocks(BlockListImpl.java:128)
>> [junit] at
>> org.apache.poi.poifs.filesystem.POIFSFileSystem.processProperties(POIFSFileSystem.java:403)
>> [junit] at
>> org.apache.poi.poifs.filesystem.POIFSFileSystem.<init>(POIFSFileSystem.java:102)
>> [junit] at
>> org.apache.poi.poifs.filesystem.TestEmptyDocument.testSingleEmptyDocument(TestEmptyDocument.java:94)
>
> Best regards
> Rainer Klute
>
> Rainer Klute IT-Consulting GmbH
> Dipl.-Inform.
> Rainer Klute E-Mail: klute@rainer-klute.de
> K�rner Grund 24 Telefon: +49 172 2324824
> D-44143 Dortmund Telefax: +49 231 5349423
>
> Inhibit software patents: http://www.nosoftwarepatents.com/
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> Mailing List: http://jakarta.apache.org/site/mail2.html#poi
> The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
Re: o.a.pi.poifs.filesystem.TestEmptyDocument fails on HEAD
Posted by Rainer Klute <kl...@rainer-klute.de>.
Avik,
this testcase never ran successfully. I added it once because someone
sent an error report and complained that reading an empty document does
not work. The testcase verifies that by creating an empty document and
trying to read it back in.
I fiddeled around with POIFS a little bit but due to lack of time and
lack of knowledge about POIFS I couldn't find a solution. However, I
believe that this is an error and someone who knows POIFS better than me
should try to solve that issue.
Am Mittwoch, den 20.04.2005, 18:02 +0530 schrieb Avik Sengupta:
> with the following error. Ideas?? Can someone confirm this with latest
> CVS HEAD?
> (ant -Dtestcase=org.apache.poi.poifs.filesystem.TestEmptyDocument
> single-test)
>
> [junit] Testcase: testSingleEmptyDocument took 0.113 sec
> [junit] Caused an ERROR
> [junit] Cannot remove block[ 0 ]; out of range
> [junit] java.io.IOException: Cannot remove block[ 0 ]; out of range
> [junit] at
> org.apache.poi.poifs.storage.BlockListImpl.remove(BlockListImpl.java:103)
> [junit] at
> org.apache.poi.poifs.storage.BlockAllocationTableReader.fetchBlocks(BlockAllocationTableReader.java:190)
> [junit] at
> org.apache.poi.poifs.storage.BlockListImpl.fetchBlocks(BlockListImpl.java:128)
> [junit] at
> org.apache.poi.poifs.filesystem.POIFSFileSystem.processProperties(POIFSFileSystem.java:403)
> [junit] at
> org.apache.poi.poifs.filesystem.POIFSFileSystem.<init>(POIFSFileSystem.java:102)
> [junit] at
> org.apache.poi.poifs.filesystem.TestEmptyDocument.testSingleEmptyDocument(TestEmptyDocument.java:94)
Best regards
Rainer Klute
Rainer Klute IT-Consulting GmbH
Dipl.-Inform.
Rainer Klute E-Mail: klute@rainer-klute.de
Körner Grund 24 Telefon: +49 172 2324824
D-44143 Dortmund Telefax: +49 231 5349423
Inhibit software patents: http://www.nosoftwarepatents.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/