You are viewing a plain text version of this content. The canonical link for it is here.

Posted to adffaces-dev@incubator.apache.org by Srinathreddy Komatireddy <sr...@oracle.com> on 2007/04/26 18:00:09 UTC

ADFFACES-466 - Issues in change persistence framework code

Hi,

   Can someone please review ADFFACES-466 
<https://issues.apache.org/jira/browse/ADFFACES-466>. I have submitted a 
patch describing the issues and changes.

-Thanks,
Srinath K

Re: ADFFACES-466 - Issues in change persistence framework code

Posted by Srinathreddy Komatireddy <sr...@oracle.com>.

Hi Adam,
  I agree, Thanks for the suggestion. I will provide the new patch with 
the changes.

-Thanks,
Srinath K.

Adam Winer wrote:

> I added one comment to the issue tracker:  this patch
> adds global synchronization to the application of changes.
> This seems higly excessive!  The responsibility for
> synchronization should belong on the implementation of
> ChangeManager.getComponentChanges(), not on its
> use.  If you used a CopyOnWriteArrayList for these
> lists, wouldn't that be sufficient?
>
> -- Adam
>
>
>
> On 4/26/07, Srinathreddy Komatireddy
> <sr...@oracle.com> wrote:
>
>> Hi,
>>
>>    Can someone please review ADFFACES-466
>> <https://issues.apache.org/jira/browse/ADFFACES-466>. I have submitted a
>> patch describing the issues and changes.
>>
>> -Thanks,
>> Srinath K
>>
>

Re: ADFFACES-466 - Issues in change persistence framework code

Posted by Adam Winer <aw...@gmail.com>.

I added one comment to the issue tracker:  this patch
adds global synchronization to the application of changes.
This seems higly excessive!  The responsibility for
synchronization should belong on the implementation of
ChangeManager.getComponentChanges(), not on its
use.  If you used a CopyOnWriteArrayList for these
lists, wouldn't that be sufficient?

-- Adam

On 4/26/07, Srinathreddy Komatireddy
<sr...@oracle.com> wrote:
> Hi,
>
>    Can someone please review ADFFACES-466
> <https://issues.apache.org/jira/browse/ADFFACES-466>. I have submitted a
> patch describing the issues and changes.
>
> -Thanks,
> Srinath K
>