You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Grant Ingersoll (JIRA)" <ji...@apache.org> on 2011/07/20 22:14:59 UTC
[jira] [Created] (PIG-2182) Add more append support to
DataByteArray
Add more append support to DataByteArray
----------------------------------------
Key: PIG-2182
URL: https://issues.apache.org/jira/browse/PIG-2182
Project: Pig
Issue Type: Improvement
Reporter: Grant Ingersoll
Priority: Trivial
I was recently writing a UDF to use a DataByteArray similar to CONCAT and thought it would be convenient if DBA supported more append options similar to Appendable and also that you can string them together if you wish as in dba.append("foo").append("bar").
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2182) Add more append support to
DataByteArray
Posted by "Thejas M Nair (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130806#comment-13130806 ]
Thejas M Nair commented on PIG-2182:
------------------------------------
I also verified that adding new functions to an existing class is a binary compatible change - http://java.sun.com/docs/books/jls/second_edition/html/binaryComp.doc.html
> Add more append support to DataByteArray
> ----------------------------------------
>
> Key: PIG-2182
> URL: https://issues.apache.org/jira/browse/PIG-2182
> Project: Pig
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Trivial
> Fix For: 0.10
>
> Attachments: PIG-2182.patch
>
>
> I was recently writing a UDF to use a DataByteArray similar to CONCAT and thought it would be convenient if DBA supported more append options similar to Appendable and also that you can string them together if you wish as in dba.append("foo").append("bar").
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2182) Add more append support to
DataByteArray
Posted by "Alan Gates (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229756#comment-13229756 ]
Alan Gates commented on PIG-2182:
---------------------------------
As long as the tests pass consistently, no objections.
> Add more append support to DataByteArray
> ----------------------------------------
>
> Key: PIG-2182
> URL: https://issues.apache.org/jira/browse/PIG-2182
> Project: Pig
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Trivial
> Fix For: 0.10
>
> Attachments: PIG-2182.patch
>
>
> I was recently writing a UDF to use a DataByteArray similar to CONCAT and thought it would be convenient if DBA supported more append options similar to Appendable and also that you can string them together if you wish as in dba.append("foo").append("bar").
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2182) Add more append support to
DataByteArray
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Gates updated PIG-2182:
----------------------------
Assignee: Grant Ingersoll
> Add more append support to DataByteArray
> ----------------------------------------
>
> Key: PIG-2182
> URL: https://issues.apache.org/jira/browse/PIG-2182
> Project: Pig
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Trivial
> Fix For: 0.10
>
> Attachments: PIG-2182.patch
>
>
> I was recently writing a UDF to use a DataByteArray similar to CONCAT and thought it would be convenient if DBA supported more append options similar to Appendable and also that you can string them together if you wish as in dba.append("foo").append("bar").
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2182) Add more append support to
DataByteArray
Posted by "Daniel Dai (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-2182:
----------------------------
Attachment: PIG-2182-2.patch
Add test cases.
> Add more append support to DataByteArray
> ----------------------------------------
>
> Key: PIG-2182
> URL: https://issues.apache.org/jira/browse/PIG-2182
> Project: Pig
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Trivial
> Fix For: 0.10
>
> Attachments: PIG-2182-2.patch, PIG-2182.patch
>
>
> I was recently writing a UDF to use a DataByteArray similar to CONCAT and thought it would be convenient if DBA supported more append options similar to Appendable and also that you can string them together if you wish as in dba.append("foo").append("bar").
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2182) Add more append support to
DataByteArray
Posted by "Alan Gates (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130772#comment-13130772 ]
Alan Gates commented on PIG-2182:
---------------------------------
Reviewing this patch it looks fine. But every time I run the tests on it I see quite a few test failures. The failures are not repeatable, nor is it the same tests failing. But it's frequent enough that I'm convinced something here is causing an issue. I'll keep looking into it, but at this point I want to hold off committing this patch.
> Add more append support to DataByteArray
> ----------------------------------------
>
> Key: PIG-2182
> URL: https://issues.apache.org/jira/browse/PIG-2182
> Project: Pig
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Trivial
> Fix For: 0.10
>
> Attachments: PIG-2182.patch
>
>
> I was recently writing a UDF to use a DataByteArray similar to CONCAT and thought it would be convenient if DBA supported more append options similar to Appendable and also that you can string them together if you wish as in dba.append("foo").append("bar").
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2182) Add more append support to
DataByteArray
Posted by "Alan Gates (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122248#comment-13122248 ]
Alan Gates commented on PIG-2182:
---------------------------------
Reviewing this patch, seriously belatedly.
> Add more append support to DataByteArray
> ----------------------------------------
>
> Key: PIG-2182
> URL: https://issues.apache.org/jira/browse/PIG-2182
> Project: Pig
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Trivial
> Fix For: 0.10
>
> Attachments: PIG-2182.patch
>
>
> I was recently writing a UDF to use a DataByteArray similar to CONCAT and thought it would be convenient if DBA supported more append options similar to Appendable and also that you can string them together if you wish as in dba.append("foo").append("bar").
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2182) Add more append support to
DataByteArray
Posted by "Daniel Dai (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229752#comment-13229752 ]
Daniel Dai commented on PIG-2182:
---------------------------------
I run through the tests. I checked the patch seems nothing will break existing code. I plan to commit the patch, objection?
> Add more append support to DataByteArray
> ----------------------------------------
>
> Key: PIG-2182
> URL: https://issues.apache.org/jira/browse/PIG-2182
> Project: Pig
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Trivial
> Fix For: 0.10
>
> Attachments: PIG-2182.patch
>
>
> I was recently writing a UDF to use a DataByteArray similar to CONCAT and thought it would be convenient if DBA supported more append options similar to Appendable and also that you can string them together if you wish as in dba.append("foo").append("bar").
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2182) Add more append support to
DataByteArray
Posted by "Daniel Dai (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-2182:
----------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Patch committed 0.10/trunk. Thanks Grant!
> Add more append support to DataByteArray
> ----------------------------------------
>
> Key: PIG-2182
> URL: https://issues.apache.org/jira/browse/PIG-2182
> Project: Pig
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Trivial
> Fix For: 0.10
>
> Attachments: PIG-2182-2.patch, PIG-2182.patch
>
>
> I was recently writing a UDF to use a DataByteArray similar to CONCAT and thought it would be convenient if DBA supported more append options similar to Appendable and also that you can string them together if you wish as in dba.append("foo").append("bar").
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2182) Add more append support to
DataByteArray
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grant Ingersoll updated PIG-2182:
---------------------------------
Attachment: PIG-2182.patch
adds appends and has append return a DataByteArray.
> Add more append support to DataByteArray
> ----------------------------------------
>
> Key: PIG-2182
> URL: https://issues.apache.org/jira/browse/PIG-2182
> Project: Pig
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Priority: Trivial
> Attachments: PIG-2182.patch
>
>
> I was recently writing a UDF to use a DataByteArray similar to CONCAT and thought it would be convenient if DBA supported more append options similar to Appendable and also that you can string them together if you wish as in dba.append("foo").append("bar").
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2182) Add more append support to
DataByteArray
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Gates updated PIG-2182:
----------------------------
Fix Version/s: 0.10
Status: Patch Available (was: Open)
> Add more append support to DataByteArray
> ----------------------------------------
>
> Key: PIG-2182
> URL: https://issues.apache.org/jira/browse/PIG-2182
> Project: Pig
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Priority: Trivial
> Fix For: 0.10
>
> Attachments: PIG-2182.patch
>
>
> I was recently writing a UDF to use a DataByteArray similar to CONCAT and thought it would be convenient if DBA supported more append options similar to Appendable and also that you can string them together if you wish as in dba.append("foo").append("bar").
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira