[GitHub] [solr] jeanielamwh commented on a diff in pull request #1067: SOLR-16409: Admin UI - Expose all highlighting parameters in the Query UI

[GitBox <gi...@apache.org>]

jeanielamwh commented on code in PR #1067:
URL: https://github.com/apache/solr/pull/1067#discussion_r1017018072


##########
solr/webapp/web/js/angular/controllers/query.js:
##########
@@ -169,6 +169,9 @@ solrAdminApp.controller('QueryController',
       purgeParams(params, ["q.alt", "qf", "mm", "pf", "ps", "qs", "tie", "bq", "bf"], $scope.val.defType !== "dismax" && $scope.val.defType !== "edismax");
       purgeParams(params, ["uf", "pf2", "pf3", "ps2", "ps3", "boost", "stopwords", "lowercaseOperators"], $scope.val.defType !== "edismax");
       purgeParams(params, getDependentFields("hl"), $scope.val.hl !== true);
+      purgeParams(params, getDependentFields("hl.tag"), $scope.val["hl.method"] !== "unified" && $scope.val["hl.method"] !== "fastVector");
+      purgeParams(params, getDependentFields("hl.simple"), $scope.val["hl.method"] !== "original");
+      // TODO purge highlighter-implementation-specific params

Review Comment:
   [e2f87db](https://github.com/apache/solr/pull/1067/commits/e2f87dbddc33e0c63caa3ee86210db54ae4054dd) adds a new function to figure out the fields-to-purge based on `query.html`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org