[GitHub] [pdfbox] THausherr commented on a diff in pull request #151: PDResource font cache improvement

[GitBox <gi...@apache.org>]

THausherr commented on code in PR #151:
URL: https://github.com/apache/pdfbox/pull/151#discussion_r1073956334


##########
pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDResources.java:
##########
@@ -95,6 +96,24 @@ public PDResources(COSDictionary resourceDictionary, ResourceCache resourceCache
         }
         resources = resourceDictionary;
         cache = resourceCache;
+        directFontCache = new HashMap<COSName,SoftReference<PDFont>>();
+    }
+
+    /**
+     * Constructor for reading.
+     *
+     * @param resourceDictionary The cos dictionary for this resource.
+     * @param resourceCache The document's resource cache, may be null.
+     */

Review Comment:
   please add a good javadoc line here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org