You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "Volkan Yazici (Jira)" <ji...@apache.org> on 2021/02/11 14:39:00 UTC
[jira] [Commented] (GROOVY-6360) GString performance is slow with
String's method
[ https://issues.apache.org/jira/browse/GROOVY-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283055#comment-17283055 ]
Volkan Yazici commented on GROOVY-6360:
---------------------------------------
Is this ticket also related with the issue reported in LOG4J2-3017?
That is, {{new StringBuilder().append("person: ${person}")}} causes the {{Person#toString()}} to be called many times proportional to the length of the {{String}} returned by {{toString()}}.
> GString performance is slow with String's method
> ------------------------------------------------
>
> Key: GROOVY-6360
> URL: https://issues.apache.org/jira/browse/GROOVY-6360
> Project: Groovy
> Issue Type: Improvement
> Components: groovy-jdk
> Affects Versions: 2.1.7
> Reporter: Linh Pham
> Priority: Minor
>
> GString implementation of String's method is very expensive. With trim(), it can be 10 times slower than String's counterpart.
> *Steps to reproduce:*
> A small test program showed GString.trim() is 10 times slower than String.trim().
> {code}
> def a = " content "
> def b = " ${'content'} "
> println "a class: ${a.class}" //output: class java.lang.String
> println "b class: ${b.class}" //output: class org.codehaus.groovy.runtime.GStringImpl
> long start = System.currentTimeMillis()
> 10000000.times {
> a.trim()
> }
> println "String trim completed in ${System.currentTimeMillis() - start} ms." //output *909* ms
> start = System.currentTimeMillis()
> 10000000.times {
> b.trim()
> }
> println "GString trim completed in ${System.currentTimeMillis() - start} ms." //output: *9321 *ms
> {code}
> We can get around the problem by calling toString() on GString before invoking methods, BUT it should be supported inside the Groovy runtime.
> More info at this thread: http://markmail.org/thread/4cti6dgb7pmrzqbl
--
This message was sent by Atlassian Jira
(v8.3.4#803005)