You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/19 06:50:48 UTC

[GitHub] [spark] zhengruifeng opened a new pull request, #37927: [SPARK-40447][PS][FOLLOWUP] Fix doc of `DataFrame.corr`

zhengruifeng opened a new pull request, #37927:
URL: https://github.com/apache/spark/pull/37927

   ### What changes were proposed in this pull request?
   Fix doc of `DataFrame.corr`, it should be the implementation of `Kendall` in PS has the complexity of O(#row * #row), since it apply a cross join (within each partition) to compute the statistics
   
   
   ### Why are the changes needed?
   Fix doc of `DataFrame.corr`
   
   
   ### Does this PR introduce _any_ user-facing change?
   yes, doc fixed
   
   ### How was this patch tested?
   manually check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zhengruifeng commented on pull request #37927: [SPARK-40447][PS][FOLLOWUP] Fix doc of `DataFrame.corr`

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #37927:
URL: https://github.com/apache/spark/pull/37927#issuecomment-1250791466

   @HyukjinKwon Thank you!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #37927: [SPARK-40447][PS][FOLLOWUP] Fix doc of `DataFrame.corr`

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37927:
URL: https://github.com/apache/spark/pull/37927#issuecomment-1250785691

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zhengruifeng commented on pull request #37927: [SPARK-40447][PS][FOLLOWUP] Fix doc of `DataFrame.corr`

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #37927:
URL: https://github.com/apache/spark/pull/37927#issuecomment-1250632711

   cc @HyukjinKwon 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #37927: [SPARK-40447][PS][FOLLOWUP] Fix doc of `DataFrame.corr`

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #37927: [SPARK-40447][PS][FOLLOWUP] Fix doc of `DataFrame.corr`
URL: https://github.com/apache/spark/pull/37927


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org