You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by jpeach <gi...@git.apache.org> on 2016/05/13 17:49:26 UTC
[GitHub] trafficserver pull request: TS-4442: Fix code coverage.
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/637
TS-4442: Fix code coverage.
This fixes the code coverage configuration and removes calls to ``_exit`` that prevent coverage data being emitted. Note that we assume the fix for [TS-4441](https://issues.apache.org/jira/browse/TS-4441) and replace a couple of manual exits with ``Fatal``.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver jpeach/coverage
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/637.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #637
----
commit c8d2453ac960409ceb600899b8afcaf7c2535338
Author: James Peach <jp...@apache.org>
Date: 2016-05-13T16:14:26Z
TS-4442: Fix the --enable-coverage option.
Fix the --enable-coverage option to correctly pass the right
compilation flags. Make a special case for LuaJIT, since we don't
really want to enable coverage for third-party code.
commit b1c0f8c977c876e347671cbe97fb08f099ba8bd2
Author: James Peach <jp...@apache.org>
Date: 2016-05-13T17:44:03Z
TS-4442: Prefer exit() to _exit().
We should not be using _exit() unless the circumstances are really
exceptional. Replace all uses of _exit with exit(), except for
signal handlers and exec failures. This is necessary for emitting
code coverage data.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4442: Fix code coverage.
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/637#issuecomment-219250914
Same here, did you really intend for these branches to get pushed into the main repo?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4442: Fix code coverage.
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/637#issuecomment-219165450
@bryancall Wasn't there a reason why we changed to _exit() again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4442: Fix code coverage.
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/637#issuecomment-219195441
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4442: Fix code coverage.
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/637#issuecomment-219186427
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4442: Fix code coverage.
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/637#issuecomment-219136009
[ci approve]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4442: Fix code coverage.
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/637
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4442: Fix code coverage.
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/637#issuecomment-219113207
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---