You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/03/13 21:12:12 UTC
[GitHub] [hadoop-ozone] hanishakoneru opened a new pull request #676:
HDDS-1995. Generate renewTime on OMLeader for GetDelegationToken
hanishakoneru opened a new pull request #676: HDDS-1995. Generate renewTime on OMLeader for GetDelegationToken
URL: https://github.com/apache/hadoop-ozone/pull/676
## What changes were proposed in this pull request?
Use renewTimeInterval of the OM leader across quorum of OM's.
Right now each OM generates renew time when updating token in-memory and DB using its own configured HDDS_BLOCK_TOKEN_EXPIRY_TIME.
If different OM's have different token renew interval set, for the same token we will have different renewal time across a quorum of OM's.
This Jira is to fix this issue.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-1995
## How was this patch tested?
Currently no unit tests for GetDelegationTokenRequest. Will add in the next commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #676: HDDS-1995.
Generate renewTime on OMLeader for GetDelegationToken
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on issue #676: HDDS-1995. Generate renewTime on OMLeader for GetDelegationToken
URL: https://github.com/apache/hadoop-ozone/pull/676#issuecomment-599324156
One more issue is for a token generated, it will use leader token renewal time. But if 3 OM's have different renewal time, so token generated by OM's, whenever leader changes will have a different expiry time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 edited a comment on issue #676:
HDDS-1995. Generate renewTime on OMLeader for GetDelegationToken
Posted by GitBox <gi...@apache.org>.
bharatviswa504 edited a comment on issue #676: HDDS-1995. Generate renewTime on OMLeader for GetDelegationToken
URL: https://github.com/apache/hadoop-ozone/pull/676#issuecomment-599324156
One more issue is for a token generated, it will use leader token renewal time. But if 3 OM's have different renewal time, so token generated by OM's, whenever leader changes will have a different expiry time for different tokens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #676: HDDS-1995.
Generate renewTime on OMLeader for GetDelegationToken
Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #676: HDDS-1995. Generate renewTime on OMLeader for GetDelegationToken
URL: https://github.com/apache/hadoop-ozone/pull/676
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #676: HDDS-1995.
Generate renewTime on OMLeader for GetDelegationToken
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on issue #676: HDDS-1995. Generate renewTime on OMLeader for GetDelegationToken
URL: https://github.com/apache/hadoop-ozone/pull/676#issuecomment-599323479
Test failure is unrelated to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] hanishakoneru commented on issue #676: HDDS-1995.
Generate renewTime on OMLeader for GetDelegationToken
Posted by GitBox <gi...@apache.org>.
hanishakoneru commented on issue #676: HDDS-1995. Generate renewTime on OMLeader for GetDelegationToken
URL: https://github.com/apache/hadoop-ozone/pull/676#issuecomment-599736814
> One more issue is for a token generated, it will use leader token renewal time. But if 3 OM's have different renewal time, so token generated by OM's, whenever leader changes will have a different expiry time for different tokens.
Yes, but how do you propose to fix this? If the OMs have different renewal times, we cannot pick one over the other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #676: HDDS-1995.
Generate renewTime on OMLeader for GetDelegationToken
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on issue #676: HDDS-1995. Generate renewTime on OMLeader for GetDelegationToken
URL: https://github.com/apache/hadoop-ozone/pull/676#issuecomment-599323542
Thank you @hanishakoneru for the contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org