You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "ankitsultana (via GitHub)" <gi...@apache.org> on 2023/09/12 14:54:20 UTC

[GitHub] [pinot] ankitsultana commented on a diff in pull request #11561: Decouple metrics Key , client ID in stream consumer and add identifiers for kafka steam clientID to prevent mBean already existing instance warn in server

ankitsultana commented on code in PR #11561:
URL: https://github.com/apache/pinot/pull/11561#discussion_r1323170830


##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/PartitionGroupMetadataFetcher.java:
##########
@@ -63,8 +63,9 @@ public Exception getException() {
   @Override
   public Boolean call()
       throws Exception {
-    String clientId = PartitionGroupMetadataFetcher.class.getSimpleName() + "-"
-            + _streamConfig.getTableNameWithType() + "-" + _topicName;
+    String clientId =
+        PartitionGroupMetadataFetcher.class.getSimpleName() + "-" + _streamConfig.getTableNameWithType() + "-"

Review Comment:
   can we revert the change in this file since it's a no-op anyways?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org