You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "buraksenn (via GitHub)" <gi...@apache.org> on 2026/03/20 18:14:33 UTC

[PR] [docs] add sql example to timestamp/datetime docs for time zone [datafusion]

buraksenn opened a new pull request, #21082:
URL: https://github.com/apache/datafusion/pull/21082

   ## Which issue does this PR close?
   - Closes #19104.
   
   ## Rationale for this change
   #19104 explains but some datetime functions respect `execution.time_zone` config but there are no SQL examples for them. This PR adds it and also missing sql example for `date_part`, `extract` and `date_trunc`
   
   ## What changes are included in this PR?
   sql example changes and generated doc
   
   ## Are these changes tested?
   
   ## Are there any user-facing changes?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] [docs] add sql example to timestamp/datetime docs for time zone [datafusion]

Posted by "buraksenn (via GitHub)" <gi...@apache.org>.
buraksenn commented on PR #21082:
URL: https://github.com/apache/datafusion/pull/21082#issuecomment-4178598612

   > lgtm, thanks @buraksenn
   > 
   > Might be worth double-checking a couple of things:
   > 
   >     1. `current_time()`: Europe/London in December should be UTC+0, so the +1h offset might not hold, so it could be worth picking a timezone with a clear winter offset.
   > 
   >     2. now(): the "Z" suffix after switching to America/New_York might be incorrect since "Z" means UTC, but the return type carries the session timezone. Might want to run it locally to confirm what actually gets printed
   
   I've run the cli and verified each now. There was some mistakes thanks @berkaysynnada 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] [docs] add sql example to timestamp/datetime docs for time zone [datafusion]

Posted by "buraksenn (via GitHub)" <gi...@apache.org>.
buraksenn commented on PR #21082:
URL: https://github.com/apache/datafusion/pull/21082#issuecomment-4171456325

   Can you review this if you've time @berkaysynnada? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] [docs] add sql example to timestamp/datetime docs for time zone [datafusion]

Posted by "berkaysynnada (via GitHub)" <gi...@apache.org>.
berkaysynnada merged PR #21082:
URL: https://github.com/apache/datafusion/pull/21082


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org