[PR] github links are handled later on [camel]

["Croway (via GitHub)" <gi...@apache.org>]

Croway opened a new pull request, #12847:
URL: https://github.com/apache/camel/pull/12847

   avoid file name analysis if the name is a github link, there are some duplicated lines for github links checks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] github links are handled later on [camel]

["davsclaus (via GitHub)" <gi...@apache.org>]

davsclaus commented on code in PR #12847:
URL: https://github.com/apache/camel/pull/12847#discussion_r1459543642


##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Run.java:
##########
@@ -1294,6 +1294,11 @@ private boolean knownFile(String file) throws Exception {
     }
 
     private boolean skipFile(String name) {
+        if(name.startsWith("github:") || name.startsWith("https://github.com/")

Review Comment:
   there should be space after if 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] github links are handled later on [camel]

["Croway (via GitHub)" <gi...@apache.org>]

Croway merged PR #12847:
URL: https://github.com/apache/camel/pull/12847


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org