You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Izaak Rubin (JIRA)" <ji...@apache.org> on 2007/07/19 22:19:06 UTC
[jira] Created: (HADOOP-1637) [hbase] Fix to HScanner to Support
Filters, Add Filter Tests to TestScanner2
[hbase] Fix to HScanner to Support Filters, Add Filter Tests to TestScanner2
----------------------------------------------------------------------------
Key: HADOOP-1637
URL: https://issues.apache.org/jira/browse/HADOOP-1637
Project: Hadoop
Issue Type: Improvement
Components: contrib/hbase
Reporter: Izaak Rubin
Priority: Minor
HScanner has a non-functional support for filters. Upon writing scanner tests for filters in TestScanner2, I discovered that HScanner only increments each of its sub-scanners when the filtering decision is false. Until now this has not been a problem, because none of the other processes that use HScanner also use filters. The patch to be posted will fix the HScanner incrementation problem, and add testing for filters to TestScanner2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1637) [hbase] Fix to HScanner to Support
Filters, Add Filter Tests to TestScanner2
Posted by "Izaak Rubin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Izaak Rubin updated HADOOP-1637:
--------------------------------
Attachment: HADOOP-1637.patch
This patch makes the necessary changes to HScanner such that it now correctly handles filters. Additional tests are also added to TestScanner2 to confirm this new functionality.
The tests in TestScanner2 depend on the filters package having been updated with the patches in HADOOP-1579 and HADOOP-1606. Both of these patches should be committed before HADOOP-1637.
For clarification, the order in which these three issues should be committed is:
HADOOP-1606
HADOOP-1579
HADOOP-1637
All HBase tests have passed successfully. At present the test:
org.apache.hadoop.streaming.TestSymLink
is not functioning. Nonetheless all preceding HADOOP tests are passing, and this particular test in no way reflects on the functionality and compatibility of HBase within HADOOP.
> [hbase] Fix to HScanner to Support Filters, Add Filter Tests to TestScanner2
> ----------------------------------------------------------------------------
>
> Key: HADOOP-1637
> URL: https://issues.apache.org/jira/browse/HADOOP-1637
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Izaak Rubin
> Priority: Minor
> Attachments: HADOOP-1637.patch
>
>
> HScanner has a non-functional support for filters. Upon writing scanner tests for filters in TestScanner2, I discovered that HScanner only increments each of its sub-scanners when the filtering decision is false. Until now this has not been a problem, because none of the other processes that use HScanner also use filters. The patch to be posted will fix the HScanner incrementation problem, and add testing for filters to TestScanner2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1637) [hbase] Fix to HScanner to Support
Filters, Add Filter Tests to TestScanner2
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HADOOP-1637:
--------------------------
Status: Patch Available (was: Open)
Passes all local tests. Trying against Hudson.
> [hbase] Fix to HScanner to Support Filters, Add Filter Tests to TestScanner2
> ----------------------------------------------------------------------------
>
> Key: HADOOP-1637
> URL: https://issues.apache.org/jira/browse/HADOOP-1637
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Izaak Rubin
> Priority: Minor
> Attachments: HADOOP-1637-v2.patch, HADOOP-1637.patch
>
>
> HScanner has a non-functional support for filters. Upon writing scanner tests for filters in TestScanner2, I discovered that HScanner only increments each of its sub-scanners when the filtering decision is false. Until now this has not been a problem, because none of the other processes that use HScanner also use filters. The patch to be posted will fix the HScanner incrementation problem, and add testing for filters to TestScanner2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1637) [hbase] Fix to HScanner to Support
Filters, Add Filter Tests to TestScanner2
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HADOOP-1637:
--------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed. Thanks Izaak.
Here's a 'commit' message:
M src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestScanner2.java
(testScannerFilter) Add testing of scanners using filters.
M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HRegion.java
(next): Move on scanners even when row has been filtered.
> [hbase] Fix to HScanner to Support Filters, Add Filter Tests to TestScanner2
> ----------------------------------------------------------------------------
>
> Key: HADOOP-1637
> URL: https://issues.apache.org/jira/browse/HADOOP-1637
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Izaak Rubin
> Priority: Minor
> Attachments: HADOOP-1637-v2.patch, HADOOP-1637.patch
>
>
> HScanner has a non-functional support for filters. Upon writing scanner tests for filters in TestScanner2, I discovered that HScanner only increments each of its sub-scanners when the filtering decision is false. Until now this has not been a problem, because none of the other processes that use HScanner also use filters. The patch to be posted will fix the HScanner incrementation problem, and add testing for filters to TestScanner2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1637) [hbase] Fix to HScanner to Support
Filters, Add Filter Tests to TestScanner2
Posted by "Izaak Rubin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Izaak Rubin updated HADOOP-1637:
--------------------------------
Attachment: HADOOP-1637-v2.patch
This patch is identical to its predecessor, with the exception of a small change to the patching of HRegion. HADOOP-1637 is now a patch-on-a-patch of HADOOP-1606, as both affect HRegion. As such, the following patches MUST be applied in this order:
HADOOP-1606
HADOOP-1579
HADOOP-1637
All HBase tests have passed successfully. At present the test:
org.apache.hadoop.dfs.TestDecommission
is not functioning. Nonetheless all preceding HADOOP tests are passing, and this particular test in no way reflects on the functionality and compatibility of HBase within HADOOP.
> [hbase] Fix to HScanner to Support Filters, Add Filter Tests to TestScanner2
> ----------------------------------------------------------------------------
>
> Key: HADOOP-1637
> URL: https://issues.apache.org/jira/browse/HADOOP-1637
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Izaak Rubin
> Priority: Minor
> Attachments: HADOOP-1637-v2.patch, HADOOP-1637.patch
>
>
> HScanner has a non-functional support for filters. Upon writing scanner tests for filters in TestScanner2, I discovered that HScanner only increments each of its sub-scanners when the filtering decision is false. Until now this has not been a problem, because none of the other processes that use HScanner also use filters. The patch to be posted will fix the HScanner incrementation problem, and add testing for filters to TestScanner2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1637) [hbase] Fix to HScanner to Support
Filters, Add Filter Tests to TestScanner2
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514813 ]
Hadoop QA commented on HADOOP-1637:
-----------------------------------
+1
http://issues.apache.org/jira/secure/attachment/12362243/HADOOP-1637-v2.patch applied and successfully tested against trunk revision r558867.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/454/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/454/console
> [hbase] Fix to HScanner to Support Filters, Add Filter Tests to TestScanner2
> ----------------------------------------------------------------------------
>
> Key: HADOOP-1637
> URL: https://issues.apache.org/jira/browse/HADOOP-1637
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Izaak Rubin
> Priority: Minor
> Attachments: HADOOP-1637-v2.patch, HADOOP-1637.patch
>
>
> HScanner has a non-functional support for filters. Upon writing scanner tests for filters in TestScanner2, I discovered that HScanner only increments each of its sub-scanners when the filtering decision is false. Until now this has not been a problem, because none of the other processes that use HScanner also use filters. The patch to be posted will fix the HScanner incrementation problem, and add testing for filters to TestScanner2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.