You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/08/08 19:42:50 UTC

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4675: HBASE-27264 Add options to consider compressed size when delimiting blocks during hfile writes

bbeaudreault commented on code in PR #4675:
URL: https://github.com/apache/hbase/pull/4675#discussion_r940602279


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java:
##########
@@ -886,6 +905,27 @@ void ensureBlockReady() throws IOException {
       finishBlock();
     }
 
+    public boolean shouldFinishBlock() throws IOException {

Review Comment:
   is there a reason to have this logic here vs in HFileWriteRImpl with the rest of the `shouldfinish` logic?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org